-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge: add pausable outbox execution, inbox updating, and delayed msg enqueueing #107
Draft
DZGoldman
wants to merge
2
commits into
bridge-access-control
Choose a base branch
from
bridge-pausable
base: bridge-access-control
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+185
−39
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
| // Copyright 2021-2022, Offchain Labs, Inc. | ||
| // For license information, see https://github.com/nitro/blob/master/LICENSE | ||
| // SPDX-License-Identifier: BUSL-1.1 | ||
| import "@openzeppelin/contracts-upgradeable/access/AccessControlUpgradeable.sol"; | ||
| import { | ||
| OutboxExecutionPaused, | ||
| OutboxExecutionNotPaused, | ||
| SequencerInboxMsgsPaused, | ||
| SequencerInboxMsgsNotPaused, | ||
| DelayedMessagesEnqueuePaused, | ||
| DelayedMessagesEnqueueNotPaused | ||
| } from "../libraries/Error.sol"; | ||
| pragma solidity ^0.8.4; | ||
|
|
||
| contract BridgePausable is AccessControlUpgradeable { | ||
| bool internal _outboxExecutionPaused; | ||
| bool internal _sequencerInboxMsgsPaused; | ||
| bool internal _delayedMessageEnqueuePaused; | ||
|
|
||
| bytes32 public constant PAUSE_OUTBOX_EXECUTION_ROLE = keccak256("PAUSE_OUTBOX_EXECUTION_ROLE"); | ||
| bytes32 public constant UNPAUSE_OUTBOX_EXECUTION_ROLE = | ||
| keccak256("UNPAUSE_OUTBOX_EXECUTION_ROLE"); | ||
|
|
||
| bytes32 public constant PAUSE_SEQUENCER_INBOX_MSGS_ROLE = | ||
| keccak256("PAUSE_SEQUENCER_INBOX_MSGS_ROLE"); | ||
| bytes32 public constant UNPAUSE_SEQUENCER_INBOX_MSGS_ROLE = | ||
| keccak256("UNPAUSE_SEQUENCER_INBOX_MSGS_ROLE"); | ||
|
|
||
| bytes32 public constant PAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE = | ||
| keccak256("PAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE"); | ||
| bytes32 public constant UNPAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE = | ||
| keccak256("UNPAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE"); | ||
|
|
||
| modifier whenOutboxExecutionNotPaused() { | ||
| if (_outboxExecutionPaused) { | ||
| revert OutboxExecutionPaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier whenOutboxExecutionPaused() { | ||
| if (!_outboxExecutionPaused) { | ||
| revert OutboxExecutionNotPaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier whenSequencerInboxMsgsNotPaused() { | ||
| if (_sequencerInboxMsgsPaused) { | ||
| revert SequencerInboxMsgsPaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier whenSequencerInboxMsgsPaused() { | ||
| if (!_sequencerInboxMsgsPaused) { | ||
| revert SequencerInboxMsgsNotPaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier whenDelayedMessageEnqueueNotPaused() { | ||
| if (_delayedMessageEnqueuePaused) { | ||
| revert DelayedMessagesEnqueuePaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| modifier whenDelayedMessageEnqueuePaused() { | ||
| if (!_delayedMessageEnqueuePaused) { | ||
| revert DelayedMessagesEnqueueNotPaused(); | ||
| } | ||
| _; | ||
| } | ||
|
|
||
| function _grantAllPauseRolesTo(address owner) internal { | ||
| _grantRole(DEFAULT_ADMIN_ROLE, owner); | ||
| _grantRole(PAUSE_OUTBOX_EXECUTION_ROLE, owner); | ||
| _grantRole(UNPAUSE_OUTBOX_EXECUTION_ROLE, owner); | ||
| _grantRole(PAUSE_SEQUENCER_INBOX_MSGS_ROLE, owner); | ||
| _grantRole(UNPAUSE_SEQUENCER_INBOX_MSGS_ROLE, owner); | ||
| _grantRole(PAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE, owner); | ||
| _grantRole(UNPAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE, owner); | ||
| } | ||
|
|
||
| function pauseOutboxExecution() | ||
| external | ||
| onlyRole(PAUSE_OUTBOX_EXECUTION_ROLE) | ||
| whenOutboxExecutionNotPaused | ||
| { | ||
| _outboxExecutionPaused = true; | ||
| } | ||
|
|
||
| function unpauseOutboxExecution() | ||
| external | ||
| onlyRole(UNPAUSE_OUTBOX_EXECUTION_ROLE) | ||
| whenOutboxExecutionPaused | ||
| { | ||
| _outboxExecutionPaused = false; | ||
| } | ||
|
|
||
| function pauseSequencerInboxMsgs() | ||
| external | ||
| onlyRole(PAUSE_SEQUENCER_INBOX_MSGS_ROLE) | ||
| whenSequencerInboxMsgsNotPaused | ||
| { | ||
| _sequencerInboxMsgsPaused = true; | ||
| } | ||
|
|
||
| function unpauseSequencerInboxMsgs() | ||
| external | ||
| onlyRole(UNPAUSE_SEQUENCER_INBOX_MSGS_ROLE) | ||
| whenSequencerInboxMsgsPaused | ||
| { | ||
| _sequencerInboxMsgsPaused = false; | ||
| } | ||
|
|
||
| function pauseDelayedMsgsEnque() | ||
| external | ||
| onlyRole(PAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE) | ||
| whenDelayedMessageEnqueueNotPaused | ||
| { | ||
| _delayedMessageEnqueuePaused = true; | ||
| } | ||
|
|
||
| function unpauseDelayedMsgsEnque() | ||
| external | ||
| onlyRole(UNPAUSE_DELAYED_MESSAGE_ENQUEUE_ROLE) | ||
| whenDelayedMessageEnqueuePaused | ||
| { | ||
| _delayedMessageEnqueuePaused = false; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking maybe the separate pause/unpause roles aren't necessary (and if we wanted to split up pause/unpause affordances we could do so via smart contract wallet)