feat: anytrust fast confirmation #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahgwai
previously approved these changes
May 22, 2024
godzillaba
reviewed
Jul 3, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to OffchainLabs/bold#348 but have more validation (e.g. staker and zombie) and require sequential confirmation. Does NOT support create node and fast confirm in the same call.
Also fixed CI lacking a contract size check and overriding RollupUserLogic to use a lower optimizer-run to workaround the contract size issue
anyTrustFastConfirmerMUST also be set as validator to function, otherwise the call would revert when trying to remove zombies;setAnyTrustFastConfirmerandsetValidatorneed to be called separately due to poor event in this version and code size limit.All the change in this PR are temporary and would be superseded by #193 when BOLD ship.
resolves BLK-161