Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LLVM support in JIT build in docker #2280

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

PlasmaPower
Copy link
Collaborator

This was linking in libffi.so, but the rust builder image of the jit binary only supports a different version of libffi than the end image used. To simplify things, this removes llvm support, since it isn't super important anyways.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 7, 2024
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- this means docker builds can't use LLVM for the replay binary but in practice cranelift performs well

@PlasmaPower PlasmaPower merged commit badf348 into master May 7, 2024
9 checks passed
@PlasmaPower PlasmaPower deleted the disable-jit-llvm branch May 7, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants