Updating new sample - msgext-northwind-inventory-csharp #143

Jegadeesh-MSFT · 2024-06-26T09:23:58Z

No description provided.

…adeesh-MSFT/Copilot-for-M365-Samples into v-jegadeesh/northwind-csharp

Pawank-MSFT

please fix the given comments

samples/msgext-northwind-inventory-csharp/MessageExtensions/DiscountedSearchCommand.cs

samples/msgext-northwind-inventory-csharp/MessageExtensions/productSearchCommand.cs

samples/msgext-northwind-inventory-csharp/Models/Model.cs

samples/msgext-northwind-inventory-csharp/Program.cs

samples/msgext-northwind-inventory-csharp/Handlers/utils.cs

samples/msgext-northwind-inventory-csharp/AdaptiveCards/successCard.json

Pawank-MSFT

looks correct, Approving!

garrytrinder

Thank you for your PR @Jegadeesh-MSFT, I've left a few comments, let's get these addressed and I'll give it another pass.

I noticed an error on the adaptive card when added to a message in Teams.

I wasn't able to test this in Copilot as the tenant I am using is having issues so that is an outstanding task for me to complete.

garrytrinder · 2024-07-05T15:51:51Z

samples/msgext-northwind-inventory-csharp/TeamsApp/appPackage/manifest.json

+{
+  "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.16/MicrosoftTeams.schema.json",
+  "manifestVersion": "1.16",
+  "version": "1.0.9",


Let's make this 1.0.0 to reflect that this is the first version of the sample.

garrytrinder · 2024-07-05T15:55:15Z

samples/msgext-northwind-inventory-csharp/README.md

+
+Version|Manifest version|Date|Author|Comments
+-------|--|--|----|--------
+1.0|1.16|November 15, 2023 |Jegadeesh V <br/> Wajeed Shaikh|Initial release for Csharp labs


Let's update the table to make it up to date:

update the version column should match the version in the manifest, ideally, 1.0.0

update the date to the current date

garrytrinder · 2024-07-05T15:58:10Z

samples/msgext-northwind-inventory-csharp/README.md

+- [Azure subscription](https://portal.azure.com)
+- [Teams Toolkit for Visual Studio](https://learn.microsoft.com/en-us/microsoftteams/platform/toolkit/toolkit-v4/install-teams-toolkit-vs?pivots=visual-studio-v17-7)
+- You will need a Microsoft work or school account with [permissions to upload custom Teams applications](https://learn.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading). The account will also need a Microsoft Copilot for Microsoft 365 license to use the extension in Copilot.
+- You will need to create [local Azure Storage](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage).


Let's update the link here to point to the relevant section in the page and remove the en-us locale, https://learn.microsoft.com/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage#running-azurite-from-an-aspnet-project

garrytrinder · 2024-07-05T16:05:32Z

samples/msgext-northwind-inventory-csharp/README.md

+- You will need a Microsoft work or school account with [permissions to upload custom Teams applications](https://learn.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading). The account will also need a Microsoft Copilot for Microsoft 365 license to use the extension in Copilot.
+- You will need to create [local Azure Storage](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage).
+
+## Setup local Azure Storage


Visual Studio 2022 has Azure Storage emulation built in, we should look to use this instead of introducing a dependency on node and the Azurite npm package. See Use the Azurite emulator for local Azure Storage development: Running Azurite from an ASP.NET project

garrytrinder · 2024-07-05T16:06:54Z

samples/msgext-northwind-inventory-csharp/TeamsApp/env/.env.local

+APP_NAME_SUFFIX=local
+
+# Generated during provision, you can also add your own variables. 
+BOT_ID=


This environment variable is not given a value after running Prepare Teams App Dependencies process so can be removed.

garrytrinder · 2024-07-05T16:23:43Z

samples/msgext-northwind-inventory-csharp/lab/Troubleshooting.md

+SECRET_STORAGE_ACCOUNT_CONNECTION_STRING=UseDevelopmentStorage=true
+~~~
+
+### Ports occupied error


This isn't relevant to Visual Studio

garrytrinder · 2024-07-05T16:23:58Z

samples/msgext-northwind-inventory-csharp/lab/Troubleshooting.md

+
+This happens if you shut down the debugger and then immediately start your app again. It takes a moment for your app to stop running and release its TCP ports. Just close the error and try again.
+
+### The app takes a long time to start after pressing F5 or the debug button


This isn't relevant to Visual Studio

garrytrinder · 2024-07-05T16:25:52Z

samples/msgext-northwind-inventory-csharp/TeamsApp/teamsapp.local.yml

+        MicrosoftAppPassword: ${{SECRET_AAD_APP_CLIENT_SECRET}}
+        MicrosoftAppType: ${{MICROSOFT_APP_TYPE}}
+        MicrosoftAppTenantId: ${{MICROSOFT_APP_TENANT_ID}}
+        StorageConnectionString: "UseDevelopmentStorage=true"


We should avoid hard coding values in the YML file. I would recommend creating an environment variable in the env.local.user file to store this value.

garrytrinder · 2024-07-05T16:27:59Z

samples/msgext-northwind-inventory-csharp/.gitignore

+[Ll]og/
+
+# Notification local store
+.notification.localstore.json


We should include the following paths:

appsettings.json

.vs

__azurite*

__blobstorage__

__queuestorage__

garrytrinder · 2024-07-05T16:28:37Z

samples/msgext-northwind-inventory-csharp/appsettings.TestTool.json

@@ -0,0 +1,12 @@
+{


The test tool isn't used, so this file can be removed.

garrytrinder · 2024-07-08T09:59:34Z

@Jegadeesh-MSFT I've made this PR draft, please mark as ready for review you've completed the requested changes 👍

garrytrinder · 2024-07-15T11:35:56Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+using Microsoft.Bot.Builder.Teams;
+using Microsoft.Bot.Schema.Teams;
+using Microsoft.Bot.Schema;
+using Newtonsoft.Json.Linq;


This is unused and can be removed.

garrytrinder · 2024-07-15T11:36:08Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+using System.Threading;
+using System.Threading.Tasks;
+using Microsoft.Extensions.Logging;
+using System;


These are unused and can be removed.

garrytrinder

Thank you for the updates @Jegadeesh-MSFT there are a few more comments to be addressed before we merge.

For some of the code changes, please keep in mind that the changes may also need to be reflected in the code tour markdown page.

garrytrinder · 2024-07-15T11:43:32Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+                var action = invokeValue.Action as AdaptiveCardInvokeAction;
+                if (action == null)
+                {
+                    throw new InvalidOperationException("AdaptiveCardInvokeAction is null");
+                }
+
+                var verb = action.Verb?.ToString();
+
+                switch (verb)
+                {
+                    case "ok":
+                        return await CardHandler.HandleTeamsCardActionUpdateStockAsync(turnContext, _configuration ,cancellationToken);
+
+                    case "restock":
+                        return await CardHandler.HandleTeamsCardActionRestockAsync(turnContext, _configuration, cancellationToken);
+
+                    case "cancel":
+                        return await CardHandler.HandleTeamsCardActionCancelRestockAsync(turnContext, _configuration, cancellationToken);
+
+                    default:
+                        return Utils.CreateActionErrorResponse((int)HttpStatusCode.OK, 0, $"ActionVerbNotSupported: {verb} is not a supported action verb.");
+                }


We can remove the cast and simplify the switch statement to use an expression

Suggested change

var action = invokeValue.Action as AdaptiveCardInvokeAction;

if (action == null)

{

throw new InvalidOperationException("AdaptiveCardInvokeAction is null");

}

var verb = action.Verb?.ToString();

switch (verb)

{

case "ok":

return await CardHandler.HandleTeamsCardActionUpdateStockAsync(turnContext, _configuration ,cancellationToken);

case "restock":

return await CardHandler.HandleTeamsCardActionRestockAsync(turnContext, _configuration, cancellationToken);

case "cancel":

return await CardHandler.HandleTeamsCardActionCancelRestockAsync(turnContext, _configuration, cancellationToken);

default:

return Utils.CreateActionErrorResponse((int)HttpStatusCode.OK, 0, $"ActionVerbNotSupported: {verb} is not a supported action verb.");

}

var action = invokeValue.Action ?? throw new InvalidOperationException("AdaptiveCardInvokeAction is null");

var verb = action.Verb?.ToString();

return verb switch

{

"ok" => await CardHandler.HandleTeamsCardActionUpdateStockAsync(turnContext, _configuration, cancellationToken),

"restock" => await CardHandler.HandleTeamsCardActionRestockAsync(turnContext, _configuration, cancellationToken),

"cancel" => await CardHandler.HandleTeamsCardActionCancelRestockAsync(turnContext, _configuration, cancellationToken),

_ => Utils.CreateActionErrorResponse((int)HttpStatusCode.OK, 0, $"ActionVerbNotSupported: {verb} is not a supported action verb."),

};

garrytrinder · 2024-07-15T11:44:58Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+            switch (query.CommandId)
+            {
+                case ProductSearchCommand.CommandId:
+                    return await ProductSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken);
+
+                case DiscountedSearchCommand.CommandId:
+                    return await DiscountedSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken);
+
+                default:
+                    throw new InvalidOperationException("Unsupported command");


We can simplify here by removing the switch statement and using an expression.

Suggested change

switch (query.CommandId)

{

case ProductSearchCommand.CommandId:

return await ProductSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken);

case DiscountedSearchCommand.CommandId:

return await DiscountedSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken);

default:

throw new InvalidOperationException("Unsupported command");

return query.CommandId switch

{

ProductSearchCommand.CommandId => await ProductSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken),

DiscountedSearchCommand.CommandId => await DiscountedSearchCommand.HandleTeamsMessagingExtensionQueryAsync(turnContext, query, _configuration, cancellationToken),

_ => throw new InvalidOperationException("Unsupported command"),

};

garrytrinder · 2024-07-15T11:49:50Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+    public class SearchBot : TeamsActivityHandler
+    {
+        private readonly ILogger<SearchBot> _logger;
+        private readonly IConfiguration _configuration;
+
+        public SearchBot(ILogger<SearchBot> logger, IConfiguration configuration)
+        {
+            _logger = logger;
+            _configuration = configuration;
+        }


We can use a Primary constructor here

Suggested change

public class SearchBot : TeamsActivityHandler

{

private readonly ILogger<SearchBot> _logger;

private readonly IConfiguration _configuration;

public SearchBot(ILogger<SearchBot> logger, IConfiguration configuration)

{

_logger = logger;

_configuration = configuration;

}

public class SearchBot(ILogger<SearchBot> logger, IConfiguration configuration) : TeamsActivityHandler

{

private readonly ILogger<SearchBot> _logger = logger;

private readonly IConfiguration _configuration = configuration;

garrytrinder · 2024-07-15T11:57:15Z

samples/msgext-northwind-inventory-csharp/Controllers/BotController.cs

+public class BotController : ControllerBase
+{
+    private readonly IBotFrameworkHttpAdapter Adapter;
+    private readonly IBot Bot;
+
+    public BotController(IBotFrameworkHttpAdapter adapter, IBot bot)
+    {
+        Adapter = adapter;
+        Bot = bot;
+    }


We can use a primary constructor here

Suggested change

public class BotController : ControllerBase

{

private readonly IBotFrameworkHttpAdapter Adapter;

private readonly IBot Bot;

public BotController(IBotFrameworkHttpAdapter adapter, IBot bot)

{

Adapter = adapter;

Bot = bot;

}

public class BotController(IBotFrameworkHttpAdapter adapter, IBot bot) : ControllerBase

{

private readonly IBotFrameworkHttpAdapter Adapter = adapter;

private readonly IBot Bot = bot;

garrytrinder · 2024-07-15T11:59:49Z

samples/msgext-northwind-inventory-csharp/DbSetup/AzureTableSetup.cs

+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text.Json;
+using System.Threading.Tasks;
+using Azure;
+using Azure.Data.Tables;
+using msgext_northwind_inventory_csharp.Models;


Remove the unnecessary usings

Suggested change

using System;

using System.Collections.Generic;

using System.IO;

using System.Linq;

using System.Text.Json;

using System.Threading.Tasks;

using Azure;

using Azure.Data.Tables;

using msgext_northwind_inventory_csharp.Models;

using System.Text.Json;

using Azure;

using Azure.Data.Tables;

using msgext_northwind_inventory_csharp.Models;

garrytrinder · 2024-07-15T13:16:31Z

samples/msgext-northwind-inventory-csharp/Program.cs

+using msgext_northwind_inventory_csharp;
+using msgext_northwind_inventory_csharp.Bots;
+using msgext_northwind_inventory_csharp.DbSetup;
+using Microsoft.Bot.Builder;
+using Microsoft.Bot.Builder.Integration.AspNet.Core;
+using Microsoft.Bot.Connector.Authentication;
+using Microsoft.Extensions.Configuration;
+using Microsoft.Bot.Builder.BotFramework;
+using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Hosting;
+using msgext_northwind_inventory_csharp.NorthwindDB;


Remove unnecessary usings

Suggested change

using msgext_northwind_inventory_csharp;

using msgext_northwind_inventory_csharp.Bots;

using msgext_northwind_inventory_csharp.DbSetup;

using Microsoft.Bot.Builder;

using Microsoft.Bot.Builder.Integration.AspNet.Core;

using Microsoft.Bot.Connector.Authentication;

using Microsoft.Extensions.Configuration;

using Microsoft.Bot.Builder.BotFramework;

using Microsoft.Extensions.DependencyInjection;

using Microsoft.Extensions.Hosting;

using msgext_northwind_inventory_csharp.NorthwindDB;

using msgext_northwind_inventory_csharp;

using msgext_northwind_inventory_csharp.Bots;

using msgext_northwind_inventory_csharp.DbSetup;

using Microsoft.Bot.Builder;

using Microsoft.Bot.Builder.Integration.AspNet.Core;

using Microsoft.Bot.Connector.Authentication;

garrytrinder · 2024-07-15T13:17:14Z

samples/msgext-northwind-inventory-csharp/TeamsApp/teamsapp.local.yml

+  - uses: script
+    with:
+      run:
+        # echo "::set-teamsfx-env MICROSOFT_APP_TYPE=SingleTenant";
+        echo "::set-teamsfx-env MICROSOFT_APP_TYPE=MultiTenant";
+        echo "::set-teamsfx-env MICROSOFT_APP_TENANT_ID=${{AAD_APP_TENANT_ID}}";


This step seems unnecessary, what is it used for?

This part is a TTK auto generated code, It can be edited and directly we can add value "AAD_APP_TENANT_ID" and "MultiTenant" to the appsettings part in next line.

Due to naming conventions looked fine we left as it is. Please let me know if you want me to edit it.

garrytrinder · 2024-07-15T13:45:01Z

samples/msgext-northwind-inventory-csharp/lab/Exercise 03 - Run in Copilot.md

+> IMPORTANT - Microsoft Copilot for Microsoft 365 only works in the "New" Teams. Please don't miss this step! 
+
+> If you restart your debugger after switching to "New" teams, you may get an error message after the debugger starts. This is a known problem; please just close the error dialog and continue testing.


Block quotes formatting should be surrounded by squared brackets, be prefixed with an exclamation mark and on it's own line for correct formatting to be applied.

Suggested change

> IMPORTANT - Microsoft Copilot for Microsoft 365 only works in the "New" Teams. Please don't miss this step!

> If you restart your debugger after switching to "New" teams, you may get an error message after the debugger starts. This is a known problem; please just close the error dialog and continue testing.

> [!IMPORTANT]

> Microsoft Copilot for Microsoft 365 only works in the "New" Teams. Please don't miss this step!

> If you restart your debugger after switching to "New" teams, you may get an error message after the debugger starts. This is a known problem; please just close the error dialog and continue testing.

garrytrinder · 2024-07-15T13:46:29Z

samples/msgext-northwind-inventory-csharp/lab/Troubleshooting.md

+
+

Let's remove this additional empty space

garrytrinder · 2024-07-15T13:50:55Z

samples/msgext-northwind-inventory-csharp/Bot/SearchBot.cs

+using Newtonsoft.Json;
+using msgext_northwind_inventory_csharp.Handlers;
+
+namespace msgext_northwind_inventory_csharp.Bots


Let's update the namespace with a friendlier name

Suggested change

namespace msgext_northwind_inventory_csharp.Bots

namespace NorthwindInventory.Bots

Jegadeesh-MSFT · 2024-07-19T06:05:29Z

Hi @garrytrinder ,

We have fixed all the PR comments. For the two items below, we need confirmation.

1 . #143 (comment)
2. #143 (comment)

Thanks !

CC: @Wajeed-msft

garrytrinder · 2024-07-29T10:40:10Z

Thanks @Jegadeesh-MSFT,

I'm getting the following error when following the instructions in Exercise 01 - Set up.md

"The program cannot proceed as the following environment variables are missing: 'SECRET_STORAGE_CONNECTION_STRING', which are required for file: E:\\Copilot-for-M365-Plugins-Samples\\samples\\msgext-northwind-inventory-csharp\\TeamsApp\\teamsapp.local.yml. Make sure the required variables are set either by editing the .env file 'E:\\Copilot-for-M365-Plugins-Samples\\samples\\msgext-northwind-inventory-csharp\\TeamsApp\\env\\.env.local' with the correct names and values , or by setting the syste...

Jegadeesh-MSFT · 2024-07-30T04:57:30Z

Hi @garrytrinder ,

The error seems to be caused by the missing SECRET_STORAGE_CONNECTION_STRING in the .env file. I will check and update it accordingly.

Thanks !

Jegadeesh-MSFT · 2024-07-31T04:47:23Z

Hi @garrytrinder ,

Fixed the issue and updated the exercises accordingly. Please verify from your end.

Thanks !

garrytrinder · 2024-08-01T10:52:04Z

Thanks for the updates @Jegadeesh-MSFT 👍

Jegadeesh-MSFT and others added 9 commits June 26, 2024 14:53

Updating new sample - msgext-northwind-inventory-csharp

0b3e934

.Teamsapp and .Vs folders deleted

81d3540

TTK implemented and lab exercise edited

a0bc384

TTK user file added

4eba098

TTK Solution file updated

81d289a

Rename productSearchCommand.cs to ProductSearchCommand.cs

9c52f77

Rename utils.cs to Utils.cs

a153348

updating version history

afde044

Merge branch 'v-jegadeesh/northwind-csharp' of https://github.com/Jeg…

9b18335

…adeesh-MSFT/Copilot-for-M365-Samples into v-jegadeesh/northwind-csharp

Pawank-MSFT reviewed Jul 2, 2024

View reviewed changes

Fixing PR comments

306aed4

Wajeed-msft reviewed Jul 2, 2024

View reviewed changes

samples/msgext-northwind-inventory-csharp/Handlers/utils.cs Outdated Show resolved Hide resolved

samples/msgext-northwind-inventory-csharp/AdaptiveCards/successCard.json Outdated Show resolved Hide resolved

Jegadeesh-MSFT added 2 commits July 2, 2024 17:07

Updating adaptive cards edit and success

0586d52

Adding lab files 4 and 5

ffe2aed

Pawank-MSFT approved these changes Jul 4, 2024

View reviewed changes

garrytrinder requested changes Jul 5, 2024

View reviewed changes

Jegadeesh-MSFT added 2 commits July 8, 2024 14:14

Fixing PR comments

c98998d

Fixind gitignore file as per PR comments

061db03

garrytrinder marked this pull request as draft July 8, 2024 09:58

Jegadeesh-MSFT added 8 commits July 8, 2024 17:23

Fixing PR comments for enable multi projects

e80d508

Fixing PR comments and addind Sample env file

b62903b

Fixing PR comment of azurite

e798ea6

Pr comments fix for trobleshoot page and M365 provision images added

ce92227

Fixing PR comments ssl certificate and error in adaptive card

f0299a4

adding assets folder

124743f

Fixing the SSL certificate placement

c79c930

Fixing image name for azurite

f90385b

Jegadeesh-MSFT marked this pull request as ready for review July 11, 2024 05:55

garrytrinder reviewed Jul 15, 2024

View reviewed changes

garrytrinder requested changes Jul 15, 2024

View reviewed changes

garrytrinder marked this pull request as draft July 15, 2024 13:53

Fixing PR comments

162b11a

Jegadeesh-MSFT marked this pull request as ready for review July 24, 2024 06:57

garrytrinder self-assigned this Jul 29, 2024

Jegadeesh-MSFT added 3 commits July 30, 2024 21:24

Fixing PR comment for missing variable error

de5c125

adding appsetting.sample file

d0ec689

Fixing lab exercises links

b08bd5c

garrytrinder approved these changes Aug 1, 2024

View reviewed changes

garrytrinder merged commit 117e7c8 into OfficeDev:main Aug 1, 2024
1 check passed


		This happens if you shut down the debugger and then immediately start your app again. It takes a moment for your app to stop running and release its TCP ports. Just close the error and try again.

		### The app takes a long time to start after pressing F5 or the debug button

		> IMPORTANT - Microsoft Copilot for Microsoft 365 only works in the "New" Teams. Please don't miss this step!

		> If you restart your debugger after switching to "New" teams, you may get an error message after the debugger starts. This is a known problem; please just close the error dialog and continue testing.

	namespace msgext_northwind_inventory_csharp.Bots
	namespace NorthwindInventory.Bots

Updating new sample - msgext-northwind-inventory-csharp #143

Updating new sample - msgext-northwind-inventory-csharp #143

Conversation

Jegadeesh-MSFT commented Jun 26, 2024

Pawank-MSFT left a comment

Choose a reason for hiding this comment

Pawank-MSFT left a comment

Choose a reason for hiding this comment

garrytrinder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garrytrinder commented Jul 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

garrytrinder left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jegadeesh-MSFT commented Jul 19, 2024

garrytrinder commented Jul 29, 2024

Jegadeesh-MSFT commented Jul 30, 2024

Jegadeesh-MSFT commented Jul 31, 2024

garrytrinder commented Aug 1, 2024