Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Angular + ADAL JS as technology #42

Closed
waldekmastykarz opened this issue Sep 20, 2015 · 3 comments
Closed

Add Angular + ADAL JS as technology #42

waldekmastykarz opened this issue Sep 20, 2015 · 3 comments
Labels
enhancement fixed-on-master

Comments

@waldekmastykarz
Copy link
Contributor

Add Angular + ADAL JS as technology to simplify building add-ins connected to Office 365. Add-in generated using this technology would contain all the manual steps described in the ADAL JS manual.
@andrewconnell
Copy link
Contributor

I like the approach provided this is a new tech option and not a change to the existing angular tech option. Want to take it on @waldekmastykarz >

@jthake
Copy link
Contributor

jthake commented Oct 10, 2015

Let do it like how the angular generator has controller generators. check out script-base.js https://github.com/yeoman/generator-angular/blob/master/script-base.js
we can just have placeholder comments that file i/O can find and inject needed code.

@waldekmastykarz
Copy link
Contributor Author

Sure, I'll take it!

This was referenced Oct 13, 2015
Closed
Closed
Closed
Merged
andrewconnell added a commit that referenced this issue Oct 16, 2015
@andrewconnell
Merge pull request #71 from waldekmastykarz/issue-42
c21f369 
Added support for ADAL technology #42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed-on-master
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewconnell @jthake @waldekmastykarz