New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify bootstrapping add-ins #67
Comments
Go for it |
Aye sir! |
I'll wait with fixing this issue until we get the fix for #42 in place. That way we can do it all at once both for Angular and Angular ADAL. |
Sounds good |
If we apply the modifications we won't be needing jQuery anymore, unless you want to use some Office UI Fabric components. How about we leave the jQuery reference in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/_bower.json#L6 but comment it out in https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L9 so that it is still there and can easily be enabled if you'll want to use Office UI Fabric which requires jQuery (https://github.com/OfficeDev/generator-office/blob/master/generators/taskpane/templates/ng/index.html#L25)? |
Personally, if its not used, I’d remove it all together. Leaving commented code in starter templates always makes me wonder if that was left by mistake. People can add it quite easily if they want it. And you don’t need jQuery if you use fabric… you only need it for some of the components, not all. |
Simplified bootstrapping add-ins #67
I believe we could simplify bootstrapping the add-in by removing jQuery from
app.module.js
and slightly changing the HTML structure inindex.html
.The text was updated successfully, but these errors were encountered: