Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest file name based on project name #58

Closed
jthake opened this issue Oct 10, 2015 · 10 comments
Closed

Manifest file name based on project name #58

jthake opened this issue Oct 10, 2015 · 10 comments
Assignees

Comments

@jthake
Copy link
Contributor

jthake commented Oct 10, 2015

Rather than call every manifest "manifest.xml" actually create file name as "-manifest.xml". Makes it useful when having a shared network folder for a Trusted add-in catalog on a local machine when testing in Office Windows client.

@andrewconnell
Copy link
Contributor

You saying to literally call it -manifest.xml... simply prefix with a hyphen?

So when you reference a shared folder on the network for the Trusted Add-in Catalog, you can't name them manifest.xml?

@jthake
Copy link
Contributor Author

jthake commented Oct 10, 2015

If you have two manifest files in your Trusted Add-in Catalog (local shared folder) you can't obviously have them with teh same file name in your local drive.

yep...I think its nice to have -manifest on there just so its obvious what the file is and not just an xml file.

@andrewconnell
Copy link
Contributor

Would it be better to default to the same name as the project name you gave it? We could use the same logic we use to create the name in the package.json or bower.json file so it's all lowercase & spaces are replaced with hyphens

@jthake
Copy link
Contributor Author

jthake commented Oct 10, 2015

oh yes....sorry maybe I wasn't clear on that. Yes we use the proejct name that was asked as first question for the prefix to file name.

@waldekmastykarz
Copy link
Contributor

I would suggest using the project name as a suffix, ie. manifest-my-addin.xml. That way it would be easier to find the manifest file between all the other project files.

@andrewconnell
Copy link
Contributor

@jthake ... thoughts? This is easy to implement...

@jthake
Copy link
Contributor Author

jthake commented Oct 12, 2015

yes i see what you mean around having manifest first then the project name. good idea. Ship It1

@andrewconnell andrewconnell self-assigned this Oct 12, 2015
@waldekmastykarz
Copy link
Contributor

When building this should we take into account the manifest name set by default in the validate-xml gulp task? By default it uses manifest.xml which initially made it easy to validate the manifest by simply calling $ gulp validate-xml. With this change the developer would either need to pass the manifest file name every time to the task or we would need to change the default manifest file in gulpfile.js. What do you think?

@andrewconnell
Copy link
Contributor

@waldekmastykarz good point... I'll tweak the validation to look for manifest-*.xml

@waldekmastykarz
Copy link
Contributor

One more place where we will need to include this are tests which currently also refer to manifest.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants