New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest file name based on project name #58
Comments
You saying to literally call it So when you reference a shared folder on the network for the Trusted Add-in Catalog, you can't name them |
If you have two manifest files in your Trusted Add-in Catalog (local shared folder) you can't obviously have them with teh same file name in your local drive. yep...I think its nice to have -manifest on there just so its obvious what the file is and not just an xml file. |
Would it be better to default to the same name as the project name you gave it? We could use the same logic we use to create the name in the |
oh yes....sorry maybe I wasn't clear on that. Yes we use the proejct name that was asked as first question for the prefix to file name. |
I would suggest using the project name as a suffix, ie. |
@jthake ... thoughts? This is easy to implement... |
yes i see what you mean around having manifest first then the project name. good idea. Ship It1 |
When building this should we take into account the manifest name set by default in the |
@waldekmastykarz good point... I'll tweak the validation to look for |
One more place where we will need to include this are tests which currently also refer to |
…ename Make manifest.xml dynamic using project name, closing #58
Rather than call every manifest "manifest.xml" actually create file name as "-manifest.xml". Makes it useful when having a shared network folder for a Trusted add-in catalog on a local machine when testing in Office Windows client.
The text was updated successfully, but these errors were encountered: