Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help for the different gulp tasks #66

Closed
waldekmastykarz opened this issue Oct 13, 2015 · 11 comments
Closed

Add help for the different gulp tasks #66

waldekmastykarz opened this issue Oct 13, 2015 · 11 comments

Comments

@waldekmastykarz
Copy link
Contributor

Since we're now having multiple gulp tasks, how about we added help to make it easier to use them?

@andrewconnell
Copy link
Contributor

All you :)

Each one has a comment in the header within the code... if you just run gulp help it gives you a list of the available ones. Personally I think this is enough.

@waldekmastykarz
Copy link
Contributor Author

I meant the tasks in the generated gulpfile.js rather than the generator itself. Initially it was only serve-static but now we also have validate-xml which can be called with some parameters. Unfortunately when adding the task we haven't added any documentation.

@andrewconnell
Copy link
Contributor

Ah… ok go for it

@waldekmastykarz
Copy link
Contributor Author

In the generator we're using the taskhelp package to list all available tasks. For the generated gulpfile.js this wouldn't add that much value since we only have two tasks.
What I had in mind though was to document how to use the validate-xml task since it accepts parameters. One way to do that would be to use for example https://www.npmjs.com/package/gulp-help instead which is able to list the parameters supported by a specific task. I'm not convinced though about the way you document the parameters which you do by passing an additional parameter to the gulp.task() function (see https://www.npmjs.com/package/gulp-help#taskoptions-options) which isn't documented on Gulp. Any thoughts @andrewconnell?

@andrewconnell
Copy link
Contributor

Nah… if you want feel free to implement this.

@waldekmastykarz
Copy link
Contributor Author

Let's keep it as-is then. Should the generated gulpfile.js grow in the future we can always decide to revise this issue.

@waldekmastykarz
Copy link
Contributor Author

Got a second thought: currently the validate-xml task accepts two parameters: resultsAsJson and xmlfile. The resultsAsJson parameter has been added to support the unnecessary unit tests. When you implement #58 we won't be also needing the xmlfile parameter. Removing them will simplify the task removing the need for an extended help. A simple listing, just as the one we're having in the generator's gulpfile.js would be sufficient.

@andrewconnell
Copy link
Contributor

What's the action here? I'm lost...

@waldekmastykarz
Copy link
Contributor Author

Sorry: let's add gulp help to the generated gulpfile.js files the same way we have it for the gulpfile.js of the generator.

@andrewconnell
Copy link
Contributor

ok... are you doing this?

@waldekmastykarz
Copy link
Contributor Author

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants