More package size reductions (#2242)

* made all non-public and public string enums const * removed const from some enums that cannot be const * more enums that can't be const * changefile
OfficeDev · Mar 29, 2024 · e67f1ed · e67f1ed
1 parent d65dd53
commit e67f1ed
Show file tree

Hide file tree

Showing 23 changed files with 51 additions and 44 deletions.
diff --git a/change/@microsoft-teams-js-23031b9f-4c4f-460b-8d82-3e0cdbb78e6c.json b/change/@microsoft-teams-js-23031b9f-4c4f-460b-8d82-3e0cdbb78e6c.json
@@ -0,0 +1,7 @@
+{
+  "type": "patch",
+  "comment": "Made more enums const to reduce package size",
+  "packageName": "@microsoft/teams-js",
+  "email": "noahdarveau@microsoft.com",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/teams-js/src/internal/nestedAppAuth.ts b/packages/teams-js/src/internal/nestedAppAuth.ts
@@ -17,7 +17,7 @@ const tryPolyfillWithNestedAppAuthBridgeLogger = nestedAppAuthLogger.extend('try
  * @property {string} Request - Event name for a nested app authentication request.
  * @property {string} Response - Event name for a nested app authentication response.
  */
-export enum NestedAppAuthMessageEventNames {
+export const enum NestedAppAuthMessageEventNames {
   Request = 'NestedAppAuthRequest',
   Response = 'NestedAppAuthResponse',
 }

diff --git a/packages/teams-js/src/internal/telemetry.ts b/packages/teams-js/src/internal/telemetry.ts
@@ -44,7 +44,7 @@ export function isFollowingApiVersionTagFormat(apiVersionTag: string): boolean {
  * @internal
  * Limited to Microsoft-internal use
  */
-export enum ApiVersionNumber {
+export const enum ApiVersionNumber {
   V_1 = 'v1',
   V_2 = 'v2',
   V_3 = 'v3',

diff --git a/packages/teams-js/src/internal/videoEffectsUtils.ts b/packages/teams-js/src/internal/videoEffectsUtils.ts
@@ -174,7 +174,7 @@ function pipeVideoSourceToGenerator(
  * @hidden
  * Error messages during video frame transformation.
  */
-enum VideoFrameTransformErrors {
+const enum VideoFrameTransformErrors {
   TimestampIsNull = 'timestamp of the original video frame is null',
   UnsupportedVideoFramePixelFormat = 'Unsupported video frame pixel format',
 }

diff --git a/packages/teams-js/src/private/constants.ts b/packages/teams-js/src/private/constants.ts
@@ -4,6 +4,6 @@
  * @internal
  * Limited to Microsoft-internal use
  */
-export enum ExternalAppErrorCode {
+export const enum ExternalAppErrorCode {
   INTERNAL_ERROR = 'INTERNAL_ERROR', // Generic error
 }
diff --git a/packages/teams-js/src/private/externalAppAuthentication.ts b/packages/teams-js/src/private/externalAppAuthentication.ts
@@ -121,7 +121,7 @@ export namespace externalAppAuthentication {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum OriginalRequestType {
+  export const enum OriginalRequestType {
     ActionExecuteInvokeRequest = 'ActionExecuteInvokeRequest',
     QueryMessageExtensionRequest = 'QueryMessageExtensionRequest',
   }
@@ -142,7 +142,7 @@ export namespace externalAppAuthentication {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum InvokeResponseType {
+  export const enum InvokeResponseType {
     ActionExecuteInvokeResponse = 'ActionExecuteInvokeResponse',
     QueryMessageExtensionResponse = 'QueryMessageExtensionResponse',
   }
@@ -259,7 +259,7 @@ export namespace externalAppAuthentication {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum InvokeErrorCode {
+  export const enum InvokeErrorCode {
     INTERNAL_ERROR = 'INTERNAL_ERROR', // Generic error
   }
 

diff --git a/packages/teams-js/src/private/externalAppCardActions.ts b/packages/teams-js/src/private/externalAppCardActions.ts
@@ -24,7 +24,7 @@ export namespace externalAppCardActions {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum ActionOpenUrlType {
+  export const enum ActionOpenUrlType {
     DeepLinkDialog = 'DeepLinkDialog',
     DeepLinkOther = 'DeepLinkOther',
     DeepLinkStageView = 'DeepLinkStageView',
@@ -49,7 +49,7 @@ export namespace externalAppCardActions {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum ActionOpenUrlErrorCode {
+  export const enum ActionOpenUrlErrorCode {
     INTERNAL_ERROR = 'INTERNAL_ERROR', // Generic error
     INVALID_LINK = 'INVALID_LINK', // Deep link is invalid
     NOT_SUPPORTED = 'NOT_SUPPORTED', // Deep link is not supported

diff --git a/packages/teams-js/src/private/files.ts b/packages/teams-js/src/private/files.ts
@@ -26,7 +26,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum CloudStorageProvider {
+  export const enum CloudStorageProvider {
     Dropbox = 'DROPBOX',
     Box = 'BOX',
     Sharefile = 'SHAREFILE',
@@ -66,7 +66,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum CloudStorageProviderType {
+  export const enum CloudStorageProviderType {
     Sharepoint = 0,
     WopiIntegration,
     Google,
@@ -289,7 +289,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum SpecialDocumentLibraryType {
+  export const enum SpecialDocumentLibraryType {
     ClassMaterials = 'classMaterials',
   }
 
@@ -301,7 +301,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum DocumentLibraryAccessType {
+  export const enum DocumentLibraryAccessType {
     Readonly = 'readonly',
   }
 
@@ -345,7 +345,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum FileDownloadStatus {
+  export const enum FileDownloadStatus {
     Downloaded = 'Downloaded',
     Downloading = 'Downloading',
     Failed = 'Failed',
@@ -450,7 +450,7 @@ export namespace files {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum CloudStorageProviderFileAction {
+  export const enum CloudStorageProviderFileAction {
     Download = 'DOWNLOAD',
     Upload = 'UPLOAD',
     Delete = 'DELETE',

diff --git a/packages/teams-js/src/private/interfaces.ts b/packages/teams-js/src/private/interfaces.ts
@@ -37,7 +37,7 @@ export interface ThreadMember {
  * @internal
  * Limited to Microsoft-internal use
  */
-export enum NotificationTypes {
+export const enum NotificationTypes {
   fileDownloadStart = 'fileDownloadStart',
   fileDownloadComplete = 'fileDownloadComplete',
 }
@@ -59,7 +59,7 @@ export interface ShowNotificationParameters {
  * @internal
  * Limited to Microsoft-internal use
  */
-export enum ViewerActionTypes {
+export const enum ViewerActionTypes {
   view = 'view',
   edit = 'edit',
   editNew = 'editNew',
@@ -70,7 +70,7 @@ export enum ViewerActionTypes {
  *
  * User setting changes that can be subscribed to
  */
-export enum UserSettingTypes {
+export const enum UserSettingTypes {
   /**
    * @hidden
    * Use this key to subscribe to changes in user's file open preference

diff --git a/packages/teams-js/src/private/remoteCamera.ts b/packages/teams-js/src/private/remoteCamera.ts
@@ -156,7 +156,7 @@ export namespace remoteCamera {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum ErrorReason {
+  export const enum ErrorReason {
     CommandResetError,
     CommandZoomInError,
     CommandZoomOutError,
@@ -200,7 +200,7 @@ export namespace remoteCamera {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum SessionTerminatedReason {
+  export const enum SessionTerminatedReason {
     None,
     ControlDenied,
     ControlNoResponse,

diff --git a/packages/teams-js/src/private/teams.ts b/packages/teams-js/src/private/teams.ts
@@ -20,7 +20,7 @@ import { TeamInstanceParameters, UserJoinedTeamsInformation } from './interfaces
 const teamsTelemetryVersionNumber: ApiVersionNumber = ApiVersionNumber.V_1;
 
 export namespace teams {
-  export enum ChannelType {
+  export const enum ChannelType {
     Regular = 0,
     Private = 1,
     Shared = 2,

diff --git a/packages/teams-js/src/private/videoEffectsEx.ts b/packages/teams-js/src/private/videoEffectsEx.ts
@@ -39,7 +39,7 @@ export namespace videoEffectsEx {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum ErrorLevel {
+  export const enum ErrorLevel {
     Fatal = 'fatal',
     Warn = 'warn',
   }

diff --git a/packages/teams-js/src/public/authentication.ts b/packages/teams-js/src/public/authentication.ts
@@ -767,7 +767,7 @@ export namespace authentication {
    * @internal
    * Limited to Microsoft-internal use
    */
-  export enum DataResidency {
+  export const enum DataResidency {
     /**
      * Public
      */

diff --git a/packages/teams-js/src/public/call.ts b/packages/teams-js/src/public/call.ts
@@ -16,7 +16,7 @@ const callTelemetryVersionNumber: ApiVersionNumber = ApiVersionNumber.V_2;
  */
 export namespace call {
   /** Modalities that can be associated with a call. */
-  export enum CallModalities {
+  export const enum CallModalities {
     /** Indicates that the modality is unknown or undefined. */
     Unknown = 'unknown',
     /** Indicates that the call includes audio. */

diff --git a/packages/teams-js/src/public/constants.ts b/packages/teams-js/src/public/constants.ts
@@ -30,7 +30,7 @@ export enum HostClientType {
 }
 
 /** HostName indicates the possible hosts for your application. */
-export enum HostName {
+export const enum HostName {
   /**
    * Office.com and Office Windows App
    */
@@ -132,7 +132,7 @@ export enum UserTeamRole {
 /**
  * Dialog module dimension enum
  */
-export enum DialogDimension {
+export const enum DialogDimension {
   /** Represents a large-sized dialog box, which is typically used for displaying large amounts of content or complex workflows that require more space. */
   Large = 'large',
   /** Represents a medium-sized dialog box, which is typically used for displaying moderate amounts of content or workflows that require less space. */
@@ -153,7 +153,7 @@ import { HostVersionsInfo } from './interfaces';
 /**
  * The type of the channel with which the content is associated.
  */
-export enum ChannelType {
+export const enum ChannelType {
   /** The default channel type. Type of channel is used for general collaboration and communication within a team. */
   Regular = 'Regular',
   /** Type of channel is used for sensitive or confidential communication within a team and is only accessible to members of the channel. */

diff --git a/packages/teams-js/src/public/interfaces.ts b/packages/teams-js/src/public/interfaces.ts
@@ -186,7 +186,7 @@ export interface LocaleInfo {
 /**
  * Allowed user file open preferences
  */
-export enum FileOpenPreference {
+export const enum FileOpenPreference {
   /** Indicates that the user should be prompted to open the file in inline. */
   Inline = 'inline',
   /** Indicates that the user should be prompted to open the file in the native desktop application associated with the file type. */
@@ -200,7 +200,7 @@ export enum FileOpenPreference {
  *
  * @beta
  */
-export enum ActionObjectType {
+export const enum ActionObjectType {
   /** Represents content within a Microsoft 365 application. */
   M365Content = 'm365content',
 }
@@ -250,7 +250,7 @@ export interface SecondaryId {
  * See [commonly accessed resources](https://learn.microsoft.com/graph/api/resources/onedrive?view=graph-rest-1.0#commonly-accessed-resources).
  * @beta
  */
-export enum SecondaryM365ContentIdName {
+export const enum SecondaryM365ContentIdName {
   /** OneDrive ID */
   DriveId = 'driveId',
   /** Teams Group ID */
@@ -1054,7 +1054,7 @@ export enum ErrorCode {
 }
 
 /** @hidden */
-export enum DevicePermission {
+export const enum DevicePermission {
   GeoLocation = 'geolocation',
   Media = 'media',
 }

diff --git a/packages/teams-js/src/public/liveShareHost.ts b/packages/teams-js/src/public/liveShareHost.ts
@@ -22,7 +22,7 @@ export namespace liveShare {
    * Used in Live Share for its role verification feature.
    * For more information, visit https://learn.microsoft.com/microsoftteams/platform/apps-in-teams-meetings/teams-live-share-capabilities?tabs=javascript#role-verification-for-live-data-structures
    */
-  export enum UserMeetingRole {
+  export const enum UserMeetingRole {
     /**
      * Guest role.
      */
@@ -46,7 +46,7 @@ export namespace liveShare {
    * State of the current Live Share session's Fluid container.
    * This is used internally by the `LiveShareClient` when joining a Live Share session.
    */
-  export enum ContainerState {
+  export const enum ContainerState {
     /**
      * The call to `LiveShareHost.setContainerId()` successfully created the container mapping
      * for the current Live Share session.

diff --git a/packages/teams-js/src/public/marketplace.ts b/packages/teams-js/src/public/marketplace.ts
@@ -203,7 +203,7 @@ export namespace marketplace {
    * Represents the persona creating the cart.
    * @beta
    */
-  export enum Intent {
+  export const enum Intent {
     /**
      * @hidden
      * The cart is created by admin of an organization in Teams Admin Center.

diff --git a/packages/teams-js/src/public/media.ts b/packages/teams-js/src/public/media.ts
@@ -80,7 +80,7 @@ export namespace media {
   /**
    * Enum for file formats supported
    */
-  export enum FileFormat {
+  export const enum FileFormat {
     /** Base64 encoding */
     Base64 = 'base64',
     /** File id */

diff --git a/packages/teams-js/src/public/meeting.ts b/packages/teams-js/src/public/meeting.ts
@@ -409,7 +409,7 @@ export namespace meeting {
    *
    * @beta
    */
-  export enum MeetingReactionType {
+  export const enum MeetingReactionType {
     like = 'like',
     heart = 'heart',
     laugh = 'laugh',
@@ -426,7 +426,7 @@ export namespace meeting {
    * @remarks
    * Teams has several types of meetings to account for different user scenarios and requirements.
    */
-  export enum MeetingType {
+  export const enum MeetingType {
     /**
      * Used when the meeting type is not known.
      *
@@ -481,7 +481,7 @@ export namespace meeting {
    * @hidden
    * Hide from docs.
    */
-  export enum CallType {
+  export const enum CallType {
     /**
      * Represents a call between two people.
      *
@@ -502,7 +502,7 @@ export namespace meeting {
   /**
    * Represents the protocol option for sharing app content to the meeting stage.
    */
-  export enum SharingProtocol {
+  export const enum SharingProtocol {
     /**
      * The default protocol for sharing app content to stage. To learn more, visit https://aka.ms/teamsjs/shareAppContentToStage
      */
@@ -977,7 +977,7 @@ export namespace meeting {
   }
 
   /** The source of the join button click. */
-  export enum EventActionSource {
+  export const enum EventActionSource {
     /**
      * Source is calendar grid context menu.
      */

diff --git a/packages/teams-js/src/public/menus.ts b/packages/teams-js/src/public/menus.ts
@@ -144,7 +144,7 @@ export namespace menus {
    * @hidden
    * Represents information about type of list to display in Navigation Bar Menu.
    */
-  export enum MenuListType {
+  export const enum MenuListType {
     dropDown = 'dropDown',
     popOver = 'popOver',
   }

diff --git a/packages/teams-js/src/public/stageView.ts b/packages/teams-js/src/public/stageView.ts
@@ -60,7 +60,7 @@ export namespace stageView {
   /**
    * The open mode for stage content.
    */
-  export enum StageViewOpenMode {
+  export const enum StageViewOpenMode {
     /**
      * Open the content in a modal.
      */