Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
const
as possible. You can read the description for this PR for an explanation of why making enums const can when possible can make the package size smaller. I wasn't able to just go through all of the enums in teamsjs and blindly make themconst
since with the public enums, I have no way of knowing if the clients pulling the package are using the reverse mapping functionality (which making the enumconst
removes). However I was able to make most of the internal and private enumsconst
as well as all of the public string enums, since in typescript string enums do not have the reverse mapping functionality anyways, so we don't have to worry about breaking it by making it const. There are also a few miscellaneous other enums that could not be madeconst
due to other specific scenarios.Package Size Reduction
Validation
Validation performed:
Unit Tests added:
<Yes/No>
End-to-end tests added:
<Yes/No>
Additional Requirements
Change file added:
<Yes/No>
Related PRs:
Next/remaining steps:
Screenshots: