-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/mahimashukla/3 p drag and drop #1903
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until your feature request has been approved we won't be reviewing this FYI.
…OfficeDev/microsoft-teams-library-js into user/mahimashukla/3PDragAndDrop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this capability to test app for E2E test case also, how this will mimic the real scenario. For reference, please refer to this PR adding visualMedia
capability
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
packages/teams-js/src/private/filesExtensionsFor3PStorageproviders.ts
Outdated
Show resolved
Hide resolved
…OfficeDev/microsoft-teams-library-js into user/mahimashukla/3PDragAndDrop
…OfficeDev/microsoft-teams-library-js into user/mahimashukla/3PDragAndDrop
…OfficeDev/microsoft-teams-library-js into user/mahimashukla/3PDragAndDrop
…OfficeDev/microsoft-teams-library-js into user/mahimashukla/3PDragAndDrop
} | ||
|
||
/** | ||
* Helper object to assembled file chunks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please re-write this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comment related changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed:
Unit Tests added:
Yes, unit test cases are added.
End-to-end tests added:
Yes
Additional Requirements
Change file added:
Yes
Next/remaining steps:
Screenshots: