Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User/mahimashukla/3 p drag and drop #1903

Merged
merged 87 commits into from
Dec 7, 2023

Conversation

mahimaMSFT
Copy link
Contributor

@mahimaMSFT mahimaMSFT commented Aug 30, 2023

For more information about how to contribute to this repo, visit this page.

Description

Drag and drop of files in compose should upload file to 3P storage providers ( Box, Google Drive, Egnyte
etc) when default provider is not ODSP.

If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Added the API which can be used by the 3p apps to get the files which were dragged and dropped in compose, when user wants to upload in 3P apps.
  2. Unit test to test the new API's

Validation

Validation performed:

  1. Validated the code with unit test cases.
  2. Created a small local app to check if the new API's are working as expected.

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

Yes, unit test cases are added.

End-to-end tests added:

Yes

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

Yes

Next/remaining steps:

List the next or remaining steps in implementing the overall feature in subsequent PRs (or is the feature 100% complete after this?).

Remove this section if n/a

  • Item 1
  • Item 2

Screenshots:

Remove this section if n/a

Before After
< image1 > < image2 >

@mahimaMSFT mahimaMSFT marked this pull request as ready for review August 30, 2023 11:19
@mahimaMSFT mahimaMSFT requested a review from a team as a code owner August 30, 2023 11:19
@mahimaMSFT mahimaMSFT self-assigned this Sep 4, 2023
Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until your feature request has been approved we won't be reviewing this FYI.

@mahimaMSFT mahimaMSFT requested a review from a team as a code owner September 12, 2023 09:04
Copy link
Contributor

@shrshindeMSFT shrshindeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this capability to test app for E2E test case also, how this will mimic the real scenario. For reference, please refer to this PR adding visualMedia capability

}

/**
* Helper object to assembled file chunks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please re-write this comment.

Copy link
Contributor

@shrshindeMSFT shrshindeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment related changes.

Copy link
Contributor

@shrshindeMSFT shrshindeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@TrevorJoelHarris TrevorJoelHarris merged commit ccbeef9 into main Dec 7, 2023
20 checks passed
@TrevorJoelHarris TrevorJoelHarris deleted the user/mahimashukla/3PDragAndDrop branch December 7, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants