-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task8134448] Implementing the visualMedia API in teamsjs #1864
Conversation
This pull request contains changes to the runtime.ts file. If you, as the author of this PR, have made changes to the Runtime interface please review RUNTIME.md to determine if a new runtime version is required. Please reply to this comment stating what changes, if any, were made to the runtime object and whether a new runtime version was required. |
470e5dc
to
a6e4de3
Compare
a6e4de3
to
fe95f66
Compare
9d3d011
to
46a6503
Compare
b0b2d2d
to
055a74c
Compare
ee4ee5a
to
0b3b2e7
Compare
04ee276
to
de54669
Compare
9974622
to
b0e49a2
Compare
@erikadoyle I will post a description by EOD today! thanks :) |
@erikadoyle thanks a lot for reminding!! :) I removed the sharepoint link to dev spec from PR description and marked all doc comments @hidden. |
change/@microsoft-teams-js-f497aa57-1549-40c6-a0f7-89b4c59a2e1f.json
Outdated
Show resolved
Hide resolved
…f.json Update changefile description
fix function naming Co-authored-by: Trevor Harris <trharris@microsoft.com>
fix function naming Co-authored-by: Trevor Harris <trharris@microsoft.com>
fix comment Co-authored-by: Trevor Harris <trharris@microsoft.com>
e5f26fc
to
382d2e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making the changes, I'm learning more about this complex capability as I review it.
fix comment. Co-authored-by: Trevor Harris <trharris@microsoft.com>
1bfc75d
382d2e8
to
1bfc75d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making changes. I've learnt a lot about VisualMedia capability. Can't wait to see developers using it. 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late comment.
Create a new API named visualMedia which will support image sub-capability.
Description
The goal of these changes is to introduce a new API called the 'visualMedia API'. It includes an image sub-capability that allows the host app to upload and capture up to 10 images for the Mos Apps.
Main changes in the PR:
Validation
Validation performed:
For captureImages: { "maxVisualMediaCount": 5, "sourceProps": { "source": 1, "cameraRestriction": 1 }, "commonImageProps": { "shouldAllowInkingOnImages": false, "shouldAllowTextStickersOnImages": false, "enableFilterOnImages": false } }
For retrieveImages: { "maxVisualMediaCount": 10, "sourceProps": {"source": 2}, "commonImageProps": { "shouldAllowInkingOnImages": false, "shouldAllowTextStickersOnImages": false, "enableFilterOnImages": false } }
Unit Tests added:
End-to-end tests added:
Change file added:
Next/remaining steps:
Screenshots: