doing feedback from SSO PM #556
Conversation
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
| @@ -551,7 +552,9 @@ There are two server-side files that need to be modified. | |||
| * The MSGraphHelper class is defined in src\msgraph-helper.ts. | |||
| * We minimize the data that must be returned by specifying that we only want the name property and only the first 3 items. | |||
|
|
|||
| `const graphData = await MSGraphHelper.getGraphData(graphToken, "/me/drive/root/children", "?$select=name&$top=3");` | |||
| ```javascript | |||
| const graphData = await MSGraphHelper.getGraphData(graphToken, "/me/drive/root/children", "?$select=name&$top=3"); | |||
There was a problem hiding this comment.
With const and await, isn't this TypeScript?
There was a problem hiding this comment.
Yes. This is a TypeScript walkthrough.
There was a problem hiding this comment.
Then the code type should be "typescript" instead of "javascript" :-)
| @@ -33,6 +33,7 @@ This article walks you through the process of enabling single sign-on (SSO) in a | |||
| > * The **Before** folder is a starter project. The UI and other aspects of the add-in that are not directly connected to SSO or authorization are already done. Later sections of this article walk you through the process of completing it. | |||
| > * The **Completed** version of the sample is just like the add-in that you would have if you completed the procedures of this article, except that the completed project has code comments that would be redundant with the text of this article. To use the completed version, just follow the instructions in this article, but replace "Before" with "Completed" and skip the sections **Code the client side** and **Code the server** side. | |||
| > * The **Completed Multitenant** version is a completed sample that supports multitenancy. Explore this sample if you intend to support Microsoft accounts from different domains with SSO. | |||
| > *Regardless of which version you use, you will need to trust a cert for the localhost. See the "IMPORTANT" note in the Readme of the repo.* | |||
There was a problem hiding this comment.
Nit: "certificate" instead of "cert"
(I'm not actually sure...)
| @@ -33,6 +33,7 @@ This article walks you through the process of enabling single sign-on (SSO) in a | |||
| > * The **Before** folder is a starter project. The UI and other aspects of the add-in that are not directly connected to SSO or authorization are already done. Later sections of this article walk you through the process of completing it. | |||
| > * The **Completed** version of the sample is just like the add-in that you would have if you completed the procedures of this article, except that the completed project has code comments that would be redundant with the text of this article. To use the completed version, just follow the instructions in this article, but replace "Before" with "Completed" and skip the sections **Code the client side** and **Code the server** side. | |||
| > * The **Completed Multitenant** version is a completed sample that supports multitenancy. Explore this sample if you intend to support Microsoft accounts from different domains with SSO. | |||
| > *Regardless of which version you use, you will need to trust a cert for the localhost. See the "IMPORTANT" note in the Readme of the repo.* | |||
There was a problem hiding this comment.
Is this meant to be another bullet point or an extension of the 'Completed Multitenant' item? Current behavior is that it's an italicized sentence in the 'Completed Multitenant' bullet point.
There was a problem hiding this comment.
It's meant to be a completely separate paragraph after the bulleted list. Fixed now.
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
| @@ -551,7 +552,9 @@ There are two server-side files that need to be modified. | |||
| * The MSGraphHelper class is defined in src\msgraph-helper.ts. | |||
| * We minimize the data that must be returned by specifying that we only want the name property and only the first 3 items. | |||
|
|
|||
| `const graphData = await MSGraphHelper.getGraphData(graphToken, "/me/drive/root/children", "?$select=name&$top=3");` | |||
| ```javascript | |||
| const graphData = await MSGraphHelper.getGraphData(graphToken, "/me/drive/root/children", "?$select=name&$top=3"); | |||
There was a problem hiding this comment.
Then the code type should be "typescript" instead of "javascript" :-)
✅ Validation status: passed
For more details, please refer to the build report. Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report. |
No description provided.