Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Unpin rxjs if possible #32

Closed
IanVS opened this issue Aug 3, 2017 · 4 comments
Closed

Unpin rxjs if possible #32

IanVS opened this issue Aug 3, 2017 · 4 comments

Comments

@IanVS
Copy link
Contributor

IanVS commented Aug 3, 2017

Hi, I see that you've pinned to rxjs version 5.2.0 instead of following semver with something like ^5.2.0. I am also using rxjs in my add-in, but at a different (more recent) version. Because of this, I now have two versions of the same package being bundled. Is it possible to use a more generous range for rxjs in this package?

Thanks!

@WrathOfZombies
Copy link
Contributor

WrathOfZombies commented Aug 3, 2017

@IanVS Sure, we can upgrade the rxjs version to the latest minor version. We pinned it for consistency :)
If you'd like please send a PR with the change.

@IanVS
Copy link
Contributor Author

IanVS commented Aug 3, 2017

Sure I can send in a PR. I'd suggest using yarn.lock and/or package.lock to maintain consistency, which will still allow consumers to use and lock to their own versions.

@WrathOfZombies
Copy link
Contributor

We do check in a yarn.lock file, so feel free to update that as a part of your PR.

@IanVS
Copy link
Contributor Author

IanVS commented Aug 6, 2017

Closed by #33

@IanVS IanVS closed this as completed Aug 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants