This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Update rxjs dependency version #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IanVS, It will cover your contributions to all Microsoft-managed open source projects. |
WrathOfZombies
approved these changes
Aug 5, 2017
|
@IanVS, please complete the CLA agreement and I can merge the pull request. |
|
@IanVS, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Signed! 👍 |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a helper library adding a non-trivial dependency into consuming projects, I think it make sense to be as liberal with the version range as possible. Meaning, it seems like this package should specify the minimum version that will work with
office-js-helpers.This would mean that apps using it which are depending on (and perhaps locked with
yarn.lockorpackage.lock) for example version5.1.0shouldn't necessarily need to also ship version5.4.2to all of their users just because of a mismatch with this helper library. As an example, this PR saves 7.88kb in my own project. Which granted isn't huge, but it's not nothing either, and slow load times in task panes is the worst. :)From what I can tell, this package is just using a pretty vanilla observable and doesn't seem to be doing anything too crazy with it, so this PR just specifies that
rxjs: ^5.0.0should be installed, while still updating theyarn.lockfile so that developers working on this project get the latest version.What do you think?