Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office 365 on the web Excel Add-in does not function correctly #4431

Open
Tom-H2oThermo opened this issue May 7, 2024 · 8 comments
Open
Assignees
Labels
Area: custom functions Issue related to the Excel custom functions feature Needs: attention 👋 Waiting on Microsoft to provide feedback Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs

Comments

@Tom-H2oThermo
Copy link

Tom-H2oThermo commented May 7, 2024

I’ve created an Excel Add-In that I have submitted to the MS Partner Center. Up to now I was really focused on Excel desktop application, but the Microsoft certification team seems to be mainly focused on Microsoft 365 web based applications. My add in works perfectly for the desktop, but not so well for the web based Excel.

Desktop:
As you enter the formula, you receive guidance:
image

Once you enter the formula, clicking on the fx to the left of the formula bar brings up a help window where you can enter values.
image

You can then click on Help on this function and it will open a web page with further details.
image

Office 365 on the web:

The web-based version doesn’t work this way:
The first step only shows the returned parameter, not the input parameter. Not the end of the world.
image

The second step where I click on the fx, it returns this
image

This is OK, not bad. But then when I click next I get this:
image

This is just wrong. It’s listing pressure twice, not pressure and enthalpy. Also, it lets me add arguments, which is also wrong. And it doesn’t list the optional parameters (units and metastable).
OK so I enter 20 for the pressure1 and 350 for pressure2, assuming that pressure2 is actually the enthalpy. And sure enough, it does return the correct value.
Also, there is no help link to the help pages.
My custom functions look like this in VS Code:
// Function OfficeDev/office-js-docs-pr#4
/**

  • Enthalpy f(P,T): (0)kJ/kg, (1)BTU/lbm, (2)kJ/kg, (3)kJ/kg
  • @customfunction
  • @helpurl https://h2othermo.com/primary_functions/enthalpy-f_pt/
  • @param {number} pressure (0)MPa, (1)psia, (2)bara, (3)kPa
  • @param {number} temperature (0)K, (1)°F, (2)°C, (3)°C
  • @param {number} [units=0] (0)SI, (1)US Customary, (2)Metric bara, (3) Metric kPa
  • @param {number} [metastable] false=normal, true=metastable
  • @returns (0)kJ/kg, (1)BTU/lbm, (2)kJ/kg, (3)kJ/kg
    */
    export function PTH(pressure, temperature, units, metastable) {
    return H2o.CallStmProp_fPT(pressure, temperature, units, Units.VectorParameters.Enthalpy, metastable);
    }

Any help would be greatly appreciated.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label May 7, 2024
@AlexJerabek
Copy link
Collaborator

Hi @Tom-H2oThermo,

Could you please provide more context in a GitHub comment? I'm disinclined to open a .pdf file posted to a public forum like this.

@AlexJerabek AlexJerabek added Needs: author feedback Waiting for author (creator) of Issue to provide more info and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels May 7, 2024
@Tom-H2oThermo
Copy link
Author

Tom-H2oThermo commented May 7, 2024 via email

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: attention 👋 Waiting on Microsoft to provide feedback and removed Needs: author feedback Waiting for author (creator) of Issue to provide more info labels May 7, 2024
@AlexJerabek
Copy link
Collaborator

Thank you. You should be able to directly paste images into a GitHub comment field.

@Tom-H2oThermo
Copy link
Author

Tom-H2oThermo commented May 7, 2024 via email

@AlexJerabek
Copy link
Collaborator

Thanks @Tom-H2oThermo. That difference in experience between desktop and web certainly seems like a bug. I'm going to transfer this to the office-js repo where a member of the custom functions feature crew can help you more.

@AlexJerabek AlexJerabek transferred this issue from OfficeDev/office-js-docs-pr May 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP label May 8, 2024
@AlexJerabek AlexJerabek added Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs Area: custom functions Issue related to the Excel custom functions feature and removed Needs: triage 🔍 New issue, needs PM on rotation to triage ASAP labels May 8, 2024
@Tom-H2oThermo
Copy link
Author

Thanks Alex. Yes it definitely seems like a bug to me. Hopefully it can be resolved soon. Thanks again.

Regards,
Tom

@ruijiaMS
Copy link

Hi @Tom-H2oThermo,
Sorry for the delay here! This is an known issue in office online Excel application and we had raised tasks 8668416 and 8668388 to track this issue. You could find the discussion from this link: #3228.
So, basically there will be a new feature for excel online including insert dialog, inline typing, arguments refactor and so on. Any update will post there! Thanks!

@Tom-H2oThermo
Copy link
Author

Tom-H2oThermo commented May 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: custom functions Issue related to the Excel custom functions feature Needs: attention 👋 Waiting on Microsoft to provide feedback Type: product bug Bug in the Office Add-ins platform or Office JavaScript APIs
Projects
None yet
Development

No branches or pull requests

4 participants