fix: sample app download images broken (#1094)

* fix: sample app download images broken * fix: cLI download samples Co-authored-by: Zhiyu You <zhiyou@microsoft.com>
OfficeDev · May 26, 2021 · 150011e · 150011e
1 parent ee2169d
commit 150011e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/cli/src/cmds/new.ts b/packages/cli/src/cmds/new.ts
@@ -225,11 +225,10 @@ class NewTemplete extends YargsCommand {
         .getEntries()
         .filter((entry) => !entry.isDirectory && entry.entryName.includes(appFolder))
         .map(async (entry) => {
-          const data = entry.getData().toString();
           const entryPath = entry.entryName.substring(entry.entryName.indexOf("/") + 1);
           const filePath = path.join(dstPath, entryPath);
           await fs.ensureDir(path.dirname(filePath));
-          await fs.writeFile(filePath, data);
+          await fs.writeFile(filePath, entry.getData());
         })
     );
   }

diff --git a/packages/fx-core/src/common/tools.ts b/packages/fx-core/src/common/tools.ts
@@ -209,11 +209,10 @@ export async function saveFilesRecursively(
       .getEntries()
       .filter((entry) => !entry.isDirectory && entry.entryName.includes(appFolder))
       .map(async (entry) => {
-        const data = entry.getData().toString();
         const entryPath = entry.entryName.substring(entry.entryName.indexOf("/") + 1);
         const filePath = path.join(dstPath, entryPath);
         await fs.ensureDir(path.dirname(filePath));
-        await fs.writeFile(filePath, data);
+        await fs.writeFile(filePath, entry.getData());
       })
   );
 }

diff --git a/packages/vscode-extension/src/controls/webviewPanel.ts b/packages/vscode-extension/src/controls/webviewPanel.ts
@@ -234,11 +234,10 @@ export class WebviewPanel {
         .getEntries()
         .filter((entry) => !entry.isDirectory && entry.entryName.includes(appFolder))
         .map(async (entry) => {
-          const data = entry.getData().toString();
           const entryPath = entry.entryName.substring(entry.entryName.indexOf("/") + 1);
           const filePath = path.join(dstPath, entryPath);
           await fs.ensureDir(path.dirname(filePath));
-          await fs.writeFile(filePath, data);
+          await fs.writeFile(filePath, entry.getData());
         })
     );
   }