inconsistent documentation about maxsyncaccounts

[listx]

In offlineimap.conf, we are told to "set the maxsyncaccounts option accordingly"

offlineimap/offlineimap.conf

Lines 276 to 277 in 67d35db

	# If you want more than one account concurrently synced in this mode, don't
	# forget to set the maxsyncaccounts option accordingly.

, but in docs/offlineimap.txt we are told that the maxsyncaccounts option is deprecated because of race conditions

offlineimap/docs/offlineimap.txt

Lines 214 to 215 in 67d35db

	WARNING: enabling the 'maxsyncaccounts' and 'maxconnections' options is
	deprecated since it's known to have race conditions.

.

So, is it supported or not?

[nicolas33]

Oh, good catch. maxsyncaccounts is supported in the case you want one instance of offlineimap syncing more than one account. Later, support for running more than one instance was added in offlineimap with a lock file at the account level. So, it's better to run as many offlineimap instances as there are accounts.

However, maxsyncaccounts is not always optionnal. It's required for autorefresh to work. If you have systemd on your system it's better to replace autorefresh with the systemd timeout service.

More on this here:

https://github.com/OfflineIMAP/offlineimap/tree/master/contrib/systemd
http://www.offlineimap.org/configuration/2016/01/29/why-i-m-not-using-maxconnctions.html

I'll fix this.

[nicolas33]

Please, let me know if the above patch looks OK to you.

[nicolas33]

Here we go. I think this version is clear enough for all the cases.

[listx]

Thanks, LGTM.

[nicolas33]

Applied. Thank you.