-
-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand environment variables in some configuration variable #113
Conversation
At which use-case these modification are targeted? You need to expand some other variable that $HOME? |
Hi,
and In my offlineimap.conf file. Location pointed by those environment variable depend on the machine I In order to only expand the HOME variable, I would have to move a lot of Konubinix |
That having said, I defer the decision to merge this to konvpalto who should be making the call. |
I'll merge this feature, but I am planning to have more generic mechanism to have filters (read, environment variable expansion and other stuff) to be done not in every function, but to make it driven by configuration hash inside the OI code. So it will take some time, though I don't expect that it will be more than a week. |
I can't wait to see it :-) |
I was about to start writing a patch for this. My use case is very similar:
|
Hi,
Do you still plan to do it. May be you can tell us exactly what should filters look like. I would be happy to write Konubinix |
It is a bit cleaner than making chains of calls like {{{ value = os.path.expanduser(value) value = os.path.abspath(value) }}} since we do see all transformations to be applied in a single iterable and have no repeated code like in the above example. Signed-off-by: Eygene Ryabinkin <rea@codelabs.ru>
For the little it's worth, +1 for pulling this in for the interim until the more sophisticated filtering system can about. |
Expand environment variables in the following configuration items: - general.pythonfile; - general.metadata; - mbnames.filename; - Repository.localfolders. - Repository.sslcacertfile. Make tilde and environment variable expansion in the following configuration items: - Repository.sslclientcert; - Repository.sslclientkey. GitHub pull request: #113 Signed-off-by: Eygene Ryabinkin <rea@codelabs.ru>
konvpalto notifications@github.com writes:
It appears to work. The code is indeed much cleaner than what I Konubinix |
Thanks a lot for your testing and proposed functionality! |
No description provided.