Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually interface with codspeed #354

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Actually interface with codspeed #354

merged 3 commits into from
Sep 1, 2023

Conversation

Ogeon
Copy link
Owner

@Ogeon Ogeon commented Sep 1, 2023

Forgot this part in #353.

@Ogeon Ogeon added the internal An internal change that will not be shown in release notes label Sep 1, 2023
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 1, 2023

CodSpeed Performance Report

Merging #354 will create unknown performance changes

Comparing improve_ci (24f483c) with master (3a9fc0e)

Summary

🆕 40 new benchmarks

Benchmarks breakdown

Benchmark master improve_ci Change
🆕 lab to lch N/A 54.7 µs N/A
🆕 xyz to lab N/A 125.8 µs N/A
🆕 xyz to yxy N/A 19.1 µs N/A
🆕 multiply_xyz_to_rgb N/A 0 ns N/A
🆕 yxy to xyz N/A 20.7 µs N/A
🆕 multiply_rgb_to_xyz N/A 0 ns N/A
🆕 rgb_to_xyz_matrix N/A 1.2 µs N/A
🆕 lab to xyz N/A 15.9 µs N/A
🆕 multiply_3x3 N/A 427.8 ns N/A
🆕 multiply_xyz N/A 0 ns N/A
🆕 matrix_inverse N/A 892.8 ns N/A
🆕 rgb to linsrgb N/A 74.2 µs N/A
🆕 linsrgb to xyz - wide f32x8 N/A 4.3 µs N/A
🆕 xyz to linsrgb N/A 12.7 µs N/A
🆕 rgb to hsl - wide f32x8 N/A 10.8 µs N/A
🆕 rgb to hsv - wide f32x8 N/A 9.6 µs N/A
🆕 rgb to hsv N/A 15.5 µs N/A
🆕 rgb to hsl N/A 18.3 µs N/A
🆕 hsv to hwb N/A 9.7 µs N/A
🆕 hsv to rgb N/A 40.5 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #354 (24f483c) into master (3a9fc0e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files         115      115           
  Lines       19751    19751           
  Branches    19751    19751           
=======================================
  Hits        15451    15451           
  Misses       4074     4074           
  Partials      226      226           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ogeon
Copy link
Owner Author

Ogeon commented Sep 1, 2023

Ouch, it needs a newer rust version... 😬

@Ogeon
Copy link
Owner Author

Ogeon commented Sep 1, 2023

Hah, putting them in their own crate worked. 😁 It's also interesting how short they run compared to boa's criterion action. It's nice to get results fast, but I wonder about the stability. I guess time will tell.

@Ogeon
Copy link
Owner Author

Ogeon commented Sep 1, 2023

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 1, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 8a2fbfa into master Sep 1, 2023
14 checks passed
@bors bors bot deleted the improve_ci branch September 1, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal change that will not be shown in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant