This repository has been archived by the owner on May 19, 2023. It is now read-only.
Make wildcards work as path variables #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The terminology surrounding this has started to feel a bit odd, now when wildcards have become variables as well. It may be time to consider using better names for these things. |
… variable sequences with labels
|
The new names are "variable segment" and "variable sequence". This may still change if better names appear before this is merged. |
|
@homu r+ |
|
📌 Commit b387c57 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 11, 2015
Make wildcards work as path variables This allows wildcards in `TreeRouter` to be named (e.x. `head/*tail`) and sent to the handler as variables. The purpose of this is to allow entire sections of the requested path to be captured as easy as individual segments currently is. This is very useful for requesting static files (see the updated `handler_storage` example). Wildcards are also renamed to "variable sequences" and standard variables are now called "variable segments". Some occurrences of the old terminology will, however, still be used in internal parts for a while longer. These changes are breaking if a project uses the LinkSegment type, or if it relies on nameless variables being available to the handler.
|
☀️ Test successful - status |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows wildcards in
TreeRouterto be named (e.x.head/*tail) and sent to the handler as variables. The purpose of this is to allow entire sections of the requested path to be captured as easy as individual segments currently is. This is very useful for requesting static files (see the updatedhandler_storageexample).Wildcards are also renamed to "variable sequences" and standard variables are now called "variable segments". Some occurrences of the old terminology will, however, still be used in internal parts for a while longer.
These changes are breaking if a project uses the LinkSegment type, or if it relies on nameless variables being available to the handler.