Remove coop.co.uk rule that breaks site functionality and is redundant #6409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule breaks functionality on coop.co.uk sites such as non-cookie modals. The rule is redundant anyway, as since it was added Co-op have switched to using OneTrust, so the extensions existing code for handling OneTrust is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule breaks functionality on coop.co.uk sites such as non-cookie-related modals.
footer ~ div{display:none !important}is a very heavy-handed CSS rule (hide anydivelement that appears in the source order after afooterelement). It was breaking modal functionality across the whole site, even modals not related to cookie prompts. React modals are often added to the very end of thebodyelement, and this means they appear after the footer. The CSS rule hid the modals, which prevented at least one*.coop.co.uksite from functioning correctly.This does not affect the functionality of the extension as that custom rule is redundant. Since it was added Co-op have switched to using OneTrust, so this extension's existing code for handling OneTrust is enough (see screenshot).
Disclosure: I work as a developer at Co-op, but I am also a user of this extension and appreciate it. I discovered this issue while investigating why I couldn't access the website that I am the tech lead for on my personal Chrome profile, but I could access it on my work Chrome profile 😁