Trying to return in response a 404 error instead of a 500, if we can … #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…show the ErrorController, but cannot a main controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что PR делает?
Добавлена обработка исключений при выполнении главного контроллера.
Зачем PR нужен?
Основное количество непредвиденых исключений приходится на работу главного контроллера. Если мы, при таком исключении, можем выполнить ErrorController и вернуть 404 ошибку с валидной страницей, чтобы пользователь смог продолжить пользоваться сайтом, то так и делаем, ошибку пишем в лог. Если ErrorController тоже возвращает исключение, тогда уже вернём 500.