Use POSIX shell arithmetic, printf instead of echo, omit quoting where obviously superfluous
#112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olf0
changed the title
printf instead of echo, omit obviously superfluous quoting
Olf0
changed the title
printf instead of echo, omit obviously superfluous quotingprintf instead of echo, omit quoting where obviously superfluous
Olf0
added a commit
that referenced
this pull request
May 3, 2023
* Update README.md * Use POSIX shell arithmetic, `printf` instead of `echo`, omit quoting where obviously superfluous (#112) * Use POSIX shell arithmetic * Use POSIX arithmetic and omit quoting … where appropriate. * Omit quoting where appropriate * Omit quoting where appropriate * `echo` --> `printf` * `echo` --> `printf` * `echo` --> `printf` * Update tidy_log-dupes * Optimise `sed` tapeworm from six to a single call * Replace double quotes by single quotes, where … … appropriate * More quoting enhancements * Pre release version increase * Do it correctly, use `eval`, see https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_19 * `grep -vx ''`→`fgrep -vx ''` * Unify quoting * Unify quoting * Unify * Unify quoting * Update post_sfos-upgrade * New intro * New intro * Update tidy_log-dupes * Update post_sfos-upgrade * Update sfos-upgrade * Update tidy_log-dupes * Update post_sfos-upgrade * Move up from `/usr/bin` to `/bin` (#113) * Rename usr/bin/post_sfos-upgrade to bin/post_sfos-upgrade * Rename usr/bin/sfos-upgrade to bin/sfos-upgrade * Rename usr/bin/tidy_log-dupes to bin/tidy_log-dupes * Executables are now originally in `/bin` instead of `/usr/bin` * Call it "SailfishOS:Chum metadata definition" * Update sfos-upgrade.spec * Move icon from `icon` to `.icon` (#114) * Move icon from `icon` to `.icon` * Move icon directory from icon to .icon --------- Co-authored-by: olf (Olf0) <Olf0@users.noreply.github.com> * Update according to version 1 of the SailfishOS:Chum metadata definition https://github.com/sailfishos-chum/main/blob/38e1f19a1617db04243d0b625a1ca7e0ae0483c5/Metadata.md * Remove entries obsoleted by commit 6ccb592 "Update according to version 1 of the SailfishOS:Chum metadata definition" * Revert commit b3bbdc0 * Simplify some `cut`s to `${foo%…}` rsp. `${bar#…}` * Adapting to Jolla's perpetual changing of formats … … and interfaces, this time https://github.com/sailfishos/docs.sailfishos.org/pull/297/files Luckily the concluding `sort -u` already handled that well, now make more obvious what has to be done. * Expand comment * Enhance comments with new knowledge about `sort` * Move check for root after options evaluation (#116) * `basename $0`→`${0##*/}` * `basename $0`→`${0##*/}` * "per"→"by" in comments * Add comment * Enhance comment * Better wording: "field" -> "tag"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.