Would you like to pull that stuff ? #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some braces... and some literal notation too. =°
…, removed some "var" statements, used the || operator for default values and moved the closures out of the setTimeout functions for better code legibility.
…e declaration out of the loop.
…n to literal and stored Spark function call in a variable out of the loop.
…comparison with undefined
…lement (some IE fix...) and removed some 'var' statements.
…declaration of offsetY.
…dded litteral fonction notation
|
After downloading your branch and testing with a document that basically tests every function of Spark I can see that is it working for the most part. Although I am getting this error when animating because the data function is not working for some reason.
Pretty strange if you ask me, why would only one function die? It just cant find |
|
Could you give me that test document ? I would be able to investigate this issue ;) |
|
Okay, I will e-mail you the document :) and I have merged in some of the changes, not all of them though because some where conflicting with a few bits I had changes, but really helpful all the same. Thanks for the effort Golmote, keep it up! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to continue exploring your code, and trying to find optimisations and new ideas for you ;)
Great job !