Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use repl.send-signal to interrupt stdio REPLs #499

Merged
merged 1 commit into from
May 28, 2023
Merged

Conversation

russtoku
Copy link
Contributor

This is a minor nit but I noticed that the stdio-based clients use two equivalent implementations of the interrupt function. This PR makes the implementation the same for these clients:

  • Hy
  • Julia
  • Python
  • Racket

by using the:

  • send-signal function defined in remote/stdio.fnl
  • vim.loop.constants.SIGINT constant instead of the number 2
  • comment-prefix of the client's language

Hopefully, this provides consistency and emphasizes the use of the base client functionality of remote/stdio.fnl.

I didn't include the Scheme client because there is #498 which adds the ability to interrupt the REPL.

@Olical Olical merged commit 9cc576e into Olical:develop May 28, 2023
2 checks passed
@Olical
Copy link
Owner

Olical commented May 28, 2023

Okay, I think that's all of your changes merged to develop fairly cleanly. Please let me know if something seems off! I'm going through myself too.

@russtoku
Copy link
Contributor Author

All seems in order. Thanks!

@russtoku russtoku deleted the dev3 branch June 6, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants