Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version checking thinks "RELEASE" is not up-to-date #11

Closed
seancorfield opened this issue Nov 19, 2018 · 9 comments
Closed

Version checking thinks "RELEASE" is not up-to-date #11

seancorfield opened this issue Nov 19, 2018 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@seancorfield
Copy link
Contributor

This is kind of a follow on from #7 but for the checking side of Depot, rather than the updating side: the version checker reports that "RELEASE" is out of date compared to whatever the latest stable release actually is.

As noted in that other ticket, we only use "RELEASE" for dev/test tooling where we always want to ensure we're always on the most recent release, without needing any manual process to update dependencies.

@Olical
Copy link
Owner

Olical commented Sep 12, 2019

Did this go away when you tried out one of the newer master commits for v2.0.0, out of interest?

@seancorfield
Copy link
Contributor Author

Hard to tell -- v2 doesn't work with our work repo setup!

@seancorfield
Copy link
Contributor Author

I just noticed that :override-deps and :extra-deps are being included in the latest commit (not sure if the user-level deps is being read tho'?), so I've pulled the latest Depot (and removed my workarounds first!) and I'm re-running my test to see if the overrides work now.

If that works, I'll go over our dev tooling and see if we still use RELEASE and then re-check this.

@seancorfield
Copy link
Contributor Author

No, it does not work yet. It is not paying any attention to the user-level deps.edn file, as far as I can tell.

@Olical
Copy link
Owner

Olical commented May 25, 2020

Sorry I completely forgot about this issue and the changes @lverns submitted, I need to get this across the line really so the master branch has a released tag. Wondering what needs to be done to finish it off, guessing it's still an issue?

@seancorfield
Copy link
Contributor Author

It's no longer an issue for me -- I no longer use Depot.

@Olical
Copy link
Owner

Olical commented May 26, 2020

Completely understandable! 😄 this tool definitely needs some love, just got to find the time and energy to do it. I'll leave this open as a note for now, would be worth bearing in mind with any changes or rewrites.

@seancorfield
Copy link
Contributor Author

In case you're curious, I ended up doing it via a fairly simple shell script that ran clojure -Stree on my code and edited the output into a new deps.edn in a temp folder with "RELEASE" in place of the actual versions, then ran clojure -Stree on that "project" and compared the output with the original deps tree (I can filter deps by depth so I can exclusive some or all transient deps).

@Olical
Copy link
Owner

Olical commented May 26, 2020 via email

@Olical Olical closed this as completed Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants