Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty coordinate maps #31

Merged
merged 3 commits into from
Sep 18, 2019
Merged

Handle empty coordinate maps #31

merged 3 commits into from
Sep 18, 2019

Conversation

lverns
Copy link
Contributor

@lverns lverns commented Sep 18, 2019

Includes the single commit from #29.

Fixes #30.

Given deps.edn as per the bug report:

{:deps {org.clojure/clojure {}}
 :aliases {:newer-stuff
           {:override-deps {org.clojure/clojure {:mvn/version "1.10.0"}}}}}

Invoking depot with no args prints:

Checking for old versions in: deps.edn
  All up to date!

Invoking with --write

Updating old versions in: deps.edn
  All up to date!

and leaves the file unchanged.


Invoking with --every:

Checking for old versions in: deps.edn
  org.clojure/clojure {:mvn/version "1.10.0"} -> {:mvn/version "1.10.1"}

Invoking with --every and --write:

Updating old versions in: deps.edn
  org.clojure/clojure {:mvn/version "1.10.0"} -> {:mvn/version "1.10.1"}

and the file is now

{:deps {org.clojure/clojure {}}
 :aliases {:newer-stuff
           {:override-deps {org.clojure/clojure {:mvn/version "1.10.1"}}}}}

@Olical
Copy link
Owner

Olical commented Sep 18, 2019

Awesome stuff! I'll review and merge at some point soon 😄

Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Olical Olical merged commit cc9e732 into Olical:master Sep 18, 2019
@Olical
Copy link
Owner

Olical commented Sep 18, 2019

I was thinking this would fix all of Sean's woes but I think this one persists 🤔 I'll have to try it myself #11 (comment)

@Olical
Copy link
Owner

Olical commented Sep 18, 2019

Thank you very much for the fixes! :D

@lverns lverns deleted the fix-issue-30 branch September 18, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception encountered when updating empty version map
2 participants