Make events work like the normal DOM

[Olical]

This involves the following changes which should help with things like #4.

• Calling addEventListener multiple times should allow you to add multiple listeners.
• Events such as mouse events should pass the native event through, not the synthetic React event.

On listeners...

Right now I have a dumb approach which removes the previous listener and replaces it because I'm just setting props.onClick, for example. This needs to basically delegate to some event system that allows you to add or remove multiple listeners. An abstraction on top of Reacts event system to make it behave like the DOM.

On event objects...

This should allow things like d3.mouse to work, right now it completely fails, you have to hit d3.event and work it out yourself.

[martpie]

Give that man à cookie...

Thanks a lot !

[Olical]

No problem :D I needed something to do on this five hour long train ride!
On 11 Oct 2015 9:17 pm, "Pierre de la Martinière" notifications@github.com
wrote:

Give that man à cookie...

Thanks a lot !

—
Reply to this email directly or view it on GitHub
#9 (comment)
.

[tristanguigue]

I can't seem to get d3.mouse to work still. It throws a TypeError: container.getBoundingClientRect is not a function

Using this (simplified) example:

let container = d3.select(ReactFauxDOM.createElement('svg'));
container.selectAll('g')
    .data(data)
  .enter().append('g')
    .append('path')
    .attr('d', function(d) {return line(d.values);})
    .on('mouseover', function() {
        let pos = d3.mouse(this) // throws an error
    });

Any reason why this is?

[alexyuly]

@tristanguigue +1. I'm getting the same error (container.getBoundingClientRect is not a function) calling a D3 zoom behavior on an SVG element appended to a <div> created with react-faux-dom, like so (simplified for clarity):

d3.select(createElement('div'))
  .append('svg')
    .call(d3.behavior.zoom().on('zoom', () => { ... })
    .append('g');

Perhaps I am missing something.

[Olical]

Interesting, would you like to open another issue with some steps to reproduce? Once we have tests for it, it'll be a lot easier.

[sungwoncho]

@Olical I think I found a related issue. Please see #66.