Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml, drop Python 2 support #70

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

harkabeeparolus
Copy link
Collaborator

Hi,

I made a pyproject.toml file, switched to reading text files with importlib.resources, and verified that the package builds correctly with pip, pipx, and build. I also removed old Python 2 compatibility code.

I kept setuptools as the build backend. This could be changed, of course.

@Olivia5k
Copy link
Owner

I'll be honest, I haven't done any Python work in the last seven years. From a cursory web search, it looks like this is what the standard du jour is like? 😅

Regardless, I say it sounds like a good thing, so thank you for the patch!

@Olivia5k Olivia5k merged commit 8ec03c7 into Olivia5k:main Dec 20, 2023
@harkabeeparolus
Copy link
Collaborator Author

I still use doge daily in all my terminal windows, which always gets funny comments from my colleagues, and I've helped several of them install it on their own accounts. 😁

I work as a Python developer, and while the packaging landscape is evolving quickly, I believe this is a safe choice.

I would be interested in working more on this project if that's ok. 😊

@Olivia5k
Copy link
Owner

Hah, glad to hear that it's spreading a bit of joy. 😊

I've invited you to be a collaborator! Feel free to push some stuff! 🙂

@harkabeeparolus harkabeeparolus deleted the packaging branch December 20, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants