Reformat with ruff, and fix linting warnings #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olivia5k
reviewed
Feb 10, 2024
|
I think I'm pretty happy with this one now... It still works great on both macOS and Linux, and I've silenced all the warnings from ruff, flake8, pylint, etc. The only remaining warnings are in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran
ruff formatandruff check --preview, and fixed most of the warnings.I used
ruff check --preview --unsafe-fixes --fixwhere possible.(This is comparable to black, isort, pyupgrade, flake8, and various other linters.)
This PR is pretty huge due to the auto formatting and switching from single quotes (') to double ("). The individual commits show the steps a little bit at a time.