Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSSTUDIO-2059: deprecate log nav buttons #145

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

cjenkscybercom
Copy link
Collaborator

@cjenkscybercom cjenkscybercom commented Apr 10, 2024

Summary of Changes

  • removes the prev/next nav buttons

Before:
image

Now:
Screenshot 2024-04-10 at 15 42 26

Visual Inspection

  • Conformance to Markdown styles: https://olog.esss.lu.se/Olog/help/CommonmarkCheatsheet
    • ...when viewing a log entry
    • ...when previewing HTML while writing a description
    • ...when viewing a log entry in the group view
  • Scroll is possible (elements don't overflow their container, and they are scrollable)
    • ...search result list
    • ...log entry group view list
    • ...log entry single view
    • ...create new log entry page
  • Overall layout fills full width and height of viewport
  • Pagination element doesn't overflow into other elements

@cjenkscybercom
Copy link
Collaborator Author

Please disregard flaky tests, they pass locally

@cjenkscybercom
Copy link
Collaborator Author

Thanks, Georg!

@cjenkscybercom cjenkscybercom merged commit 13bbc76 into main Apr 10, 2024
3 of 6 checks passed
@cjenkscybercom cjenkscybercom deleted the CSSTUDIO-2059-remove-next-prev-buttons branch April 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants