Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

[Themes] Updated themes_manager.py and JSON themes #526

Closed
wants to merge 9 commits into from
Closed

[Themes] Updated themes_manager.py and JSON themes #526

wants to merge 9 commits into from

Conversation

ArtichOwO
Copy link

No more "alone" nor "no key" colors in JSON, and there's still retro-compatibility with older themes

@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

1 similar comment
@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

themes/themes_manager.py Outdated Show resolved Hide resolved
ArtichOwO and others added 2 commits April 18, 2021 15:31
No blank line between try/except block.

Co-authored-by: Tim ats <tim.arnouts@protonmail.com>
Co-authored-by: Tim ats <tim.arnouts@protonmail.com>
@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

@M4xi1m3
Copy link
Member

M4xi1m3 commented Apr 18, 2021

Doing it like this seems like putting ducktape over a giant hole. Maybe a whole rewrite of the theme engine would be needed ? But it seems to be on the @RedGl0w list...

@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

1 similar comment
@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

ArtichOwO added a commit to ArtichOwO/OmegaThemeMakerApp that referenced this pull request Apr 19, 2021
@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 720688 bytes 400431 bytes 226872 bytes 2176 bytes 229048 bytes 1123295 bytes
Head 718512 bytes 406395 bytes 226832 bytes 2176 bytes 229008 bytes 1127083 bytes
-2176 bytes +5964 bytes -40 bytes +0 bytes -40 bytes +3788 bytes
-0.3 % +1.5 % -0.0 % +0.0 % -0.0 % +0.3 %

@OmegaRobot
Copy link

.text .rodata .bss .data Total (RAM) Total (ROM)
Base 722052 bytes 401713 bytes 226872 bytes 2176 bytes 229048 bytes 1125941 bytes
Head 722052 bytes 401713 bytes 226872 bytes 2176 bytes 229048 bytes 1125941 bytes
+0 bytes +0 bytes +0 bytes +0 bytes +0 bytes +0 bytes
+0.0 % +0.0 % +0.0 % +0.0 % +0.0 % +0.0 %

@quentinguidee quentinguidee deleted the branch Omega-Numworks:omega-dev February 2, 2024 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants