Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added in the four missing index handlers #149

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

NickRyder
Copy link
Contributor

This adds in the four missing index handlers that were triggering UnknownIdentifierWarning

One caveat here - the passive_hash handlers I believe break the paradigm of the values being fed into the handler being from the stat ranges on the mods, since the passive_hash comes from Allocates ___ on amulet/ring enchants, and these values are all ranged min = 0, max = 0. From what I can tell, the value used to create the string here comes from an attribute on the item called notableProperties.

Not sure if there are other examples of this in PyPoE I should be following, or if this behavior is unique to passive_hash

@OmegaK2 OmegaK2 merged commit c4ed368 into OmegaK2:dev Apr 25, 2021
@markliu06
Copy link

markliu06 commented Apr 25, 2021

@L1mer

Data/IndexableSupportGems.dat

Seem so. Using new merged code and manually pull some file from @brather1ng's fork for 3.14 spec does not work. Fix this line of code

    handler=lambda v: relational_reader['IndexableSupports.dat'][v]['Name'],

at least bypass the following error:

FileNotFoundError: [Errno 2] No such file or directory:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants