added in the four missing index handlers #149
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in the four missing index handlers that were triggering
UnknownIdentifierWarning
One caveat here - the
passive_hash
handlers I believe break the paradigm of the values being fed into the handler being from the stat ranges on the mods, since thepassive_hash
comes fromAllocates ___
on amulet/ring enchants, and these values are all rangedmin = 0, max = 0
. From what I can tell, the value used to create the string here comes from an attribute on the item callednotableProperties
.Not sure if there are other examples of this in PyPoE I should be following, or if this behavior is unique to
passive_hash