Seperate block height restrictions and feature activation

[dexX7]

This PR moves the helpers to get the lastest block height etc. into utilsbitcoin, and the block height restrictions, as well as the allowed input and output types into rules.

The enum BLOCKHEIGHTRESTRICTIONS was flattened to plain numbers.

From here on, I see a few options:

• move the block restrictions into a namespace, which would allow something like mastercore::consensus::P2SH_BLOCK
• provide public getters, such as IsEnabled_P2SH()
• introduce seperate restrictions for each network (i.e. main, test, regtest)
• refine and introduce a structure like Params() (see: chainparams.h, chainparams.cpp, chainparamsbase.cpp)

To go on with #104, it could basically go like this: old, already enabled features remain to have hardcoded const int block height restrictions, while the not-yet-enabled features are changed to int. There could be a function like EnableFeature_XXX(int block), which would update these values.

[zathras-crypto]

Sorry for not responding to this one sooner - I agree with your sentiments here bud and have cleaned up some local ideas to fit in with your PR here. It's a WIP but let me know what you think of zathras-crypto@fec622a.

Thanks as always mate!

[dexX7]

On the first glimpse it looks very clean and good. I'll give it a in-depth look and more thoughts later.

Can you please create a PR for it, so we have a place of discussion? :)

[zathras-crypto]

Sure dude, #129

[dexX7]

Given that #129 builds on top of this PR, should I close or merge this?

[dexX7]

I consider building on top of this PR as implicit ACK, thus the merge. :)

[dexX7]

Whoops, looks like I introduced an issue upstream:

diff --git a/src/qt/metadexdialog.cpp b/src/qt/metadexdialog.cpp
index 6838871..9ebf2c1 100755
--- a/src/qt/metadexdialog.cpp
+++ b/src/qt/metadexdialog.cpp
@@ -17,6 +17,7 @@
 #include "omnicore/parse_string.h"
 #include "omnicore/pending.h"
 #include "omnicore/sp.h"
+#include "omnicore/rules.h"
 #include "omnicore/tally.h"
 #include "omnicore/utilsbitcoin.h"

I'll wait, until my local build finished, then I'm going to push the fix.