Add blocktime to MetaDEx RPCs #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexX7
force-pushed
the
0.12-add-blocktime
branch
2 times, most recently
from
b5ac2ab
to
805fb02
Compare
dexX7
force-pushed
the
0.12-add-blocktime
branch
from
805fb02
to
c4cdb5a
Compare
|
Preliminary testing (on Debian 11 on ARM64) looks good. See related PRs: |
msgilligan
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
This looks good to me.
I have done some preliminary testing (with omni_gettradehistoryforaddress) and it seems to work correctly.
I also made changes to OmniJ to support and test this PR:
- MetaDexSpec: add some checks for OmniTradeInfo.Match properties OmniJ#217
- OmniTradeInfo.Match: add blockTime property OmniJ#218
I will do more testing once the PR is merged and we get a release-candidate binary.
counos
pushed a commit
to CounosH/counoslayer
that referenced
this pull request
Sep 27, 2023
Pull request description: This pull request adds `blocktime` to `omni_gettrade`, `omni_gettradehistoryforaddress` and `omni_gettradehistoryforpair`. This resolves OmniLayer#1264. # Conflicts: # src/counoscore/rpc.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
blocktimetoomni_gettrade,omni_gettradehistoryforaddressandomni_gettradehistoryforpair.This resolves #1264.