Merge pull request #2203 from OmniSharp/logs-project-manager

Improved logging in project manager
OmniSharp · Aug 3, 2021 · 2c3694f · 2c3694f
2 parents e55adb0 + bc5aee4
commit 2c3694f
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/OmniSharp.MSBuild/ProjectManager.cs b/src/OmniSharp.MSBuild/ProjectManager.cs
@@ -185,7 +185,7 @@ private async Task ProcessLoopAsync(CancellationToken cancellationToken)
                 }
                 catch (Exception ex)
                 {
-                    _logger.LogError($"Error occurred while processing project updates: {ex}");
+                    _logger.LogError(ex, "Error occurred while processing project updates");
                 }
             }
         }
@@ -329,7 +329,7 @@ private void ProcessQueue(CancellationToken cancellationToken)
             }
             catch (Exception ex)
             {
-                _logger.LogWarning($"Failed to load project file '{projectFilePath}'.", ex);
+                _logger.LogError(ex, "Failed to load project file '{projectFilePath}'.");
                 _eventEmitter.Error(ex, fileName: projectFilePath);
                 return (null, null);
             }
@@ -744,7 +744,7 @@ private void UpdateProjectReferences(Project project, ImmutableArray<string> pro
                 }
                 else
                 {
-                    _logger.LogDebug($"failed to get project info:{project.FilePath}");
+                    _logger.LogWarning($"Failed to get project info: {project.FilePath}");
                 }
 
                 var projectReference = new ProjectReference(referencedProject.Id, aliases);
@@ -807,13 +807,13 @@ private void UpdateReferences(Project project, ImmutableArray<string> projectRef
                             if (!string.IsNullOrEmpty(aliases))
                             {
                                 reference = reference.WithAliases(aliases.Split(new char[]{','},StringSplitOptions.RemoveEmptyEntries).Select(a => a.Trim()));
-                                _logger.LogDebug($"setting aliases: {referencePath}, {aliases} ");
+                                _logger.LogDebug($"Setting aliases: {referencePath}, {aliases} ");
                             }
                         }
                     }
                     else
                     {
-                        _logger.LogDebug($"failed to get project info:{project.FilePath}");
+                        _logger.LogDebug($"Failed to get project info: {project.FilePath}");
                     }
                     _logger.LogDebug($"Adding reference '{referencePath}' to '{project.Name}'.");
                     _workspace.AddMetadataReference(project.Id, reference);