Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Roslyn's native .editorconfig support #1657

Closed
JoeRobich opened this issue Nov 22, 2019 · 6 comments · Fixed by #1771
Closed

Use Roslyn's native .editorconfig support #1657

JoeRobich opened this issue Nov 22, 2019 · 6 comments · Fixed by #1771
Labels
editorconfig

Comments

@JoeRobich
Copy link
Member

EditorConfigDocumentOptionsProvider pulls options from Workspace.AnalyzerDocuments. Need to register this OptionsProvider with the OptionService during Workspace initialization.
@filipw filipw mentioned this issue Jan 28, 2020
Closed
@filipw filipw mentioned this issue Feb 7, 2020
Closed
@coder2000
Copy link

coder2000 commented Mar 30, 2020 •
edited
Loading

Is this supported yet?

@filipw
Copy link
Member

filipw commented Mar 30, 2020

not yet

@coder2000
Copy link

Any timeline for implementation? It gets kind of annoying having 800 warnings that are not supposed to be there.

@filipw
Copy link
Member

filipw commented Mar 30, 2020

Any timeline for implementation?

no timeline, hopefully soon

@333fred
Copy link
Contributor

333fred commented Apr 10, 2020

Also looking for this, I'm assuming my issues with analyzer settings not being respected are due to this.

@filipw
Copy link
Member

filipw commented Apr 10, 2020

yes correct, when we implemented editorconfig there was no native Roslyn support yet so we had to use the VS conventions package like dotnet format did at the time

@filipw filipw mentioned this issue Apr 13, 2020
Closed
@JoeRobich JoeRobich mentioned this issue Apr 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Roslyn's editorconfig support JoeRobich/omnisharp-roslyn
4 participants
@coder2000 @JoeRobich @filipw @333fred