Fix issue with C# projects referencing F# projects #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a long-standing problem where C# projects would attempt to load project references to non-C# projects. This is related to the problem on not adding file references for C# project references to avoid duplicate references. Now, we're a bit more selective when we decide to throw out a project or file reference: We check the file path and see if it ends with ".csproj".
DustinCampbell
requested review from
david-driscoll,
filipw,
TheRealPiotrP and
rchande
|
cc @NinoFloris as FYI |
|
I'm going to go ahead and merge this one. I don't think the change is controversial, but let me know if you have any concerns. However, I want to merge this and produce a new OmniSharp release with bug fixes (1.26.1) so @david-driscoll can merge his LSP branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/vscode-csharp#371 and dotnet/vscode-csharp#1829
This fixes a long-standing problem where C# projects would attempt to load project references
to non-C# projects. This is related to the problem on not adding file references for C# project references
to avoid duplicate references. Now, we're a bit more selective when we decide to throw out a project or file
reference: We check the file path and see if it ends with ".csproj".
I'll be porting this change into #1003 as well.