Debug only when test manager is connected #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is probably interesting enough to do a changelog entry :) |
rchande
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
Agree with @rchande -- this needs a CHANGELOG.md entry in the omnisharp-roslyn repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/vscode-csharp#2400
If there is a Build failure the test manager fails to connect and the required variables for the debug process are not initialized. However since there is no check that the TestManager is connected or not, we go ahead with the debug request and the system fails with the exception
_writer is null. However, since we entered theStartSessionmethod, the required variables are set and it appears to omnisharp-roslyn that a debug session has started whereas there is no such session. Hence any subsequent debug request is rejected with the error -Debug session started.Hence the fix is to verify whether the testManager is connected before we call the StartSession ,else fail with the relevant exception.