Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hash target frameworks and rename ProjectGuid->ProjectId #1454

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

akshita31
Copy link
Contributor

No description provided.

@akshita31 akshita31 force-pushed the do_not_hash_target_framework branch from ac66351 to 374e576 Compare April 11, 2019 21:46
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is technically a breaking change, what is the reason for the rename?

@akshita31
Copy link
Contributor Author

On the extension we would like to align it with the VS behavior so we need to call it "ProjectId" instead of "ProjectGuid"

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here it's 👍- it's a new API that was added recently for telemetry purposes, but in normal cases, for regular APIs, it would be good to make sure there are no breaking changes

@filipw filipw merged commit f605a20 into OmniSharp:master Apr 12, 2019
@akshita31 akshita31 deleted the do_not_hash_target_framework branch April 12, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants