Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn 3.4 #1597

Merged
merged 2 commits into from Sep 10, 2019
Merged

Roslyn 3.4 #1597

merged 2 commits into from Sep 10, 2019

Conversation

rchande
Copy link

@rchande rchande commented Sep 10, 2019

No description provided.

@filipw
Copy link
Member

filipw commented Sep 10, 2019

can we please merge #1596 first? i'd like to have a separate commit on master on 3.3.1 just in case we want to go back at any point

@rchande
Copy link
Author

rchande commented Sep 10, 2019

@filipw Sorry, didn't see that PR. Mind we we just supersede it with this one (given that this is a later version)?

@filipw
Copy link
Member

filipw commented Sep 10, 2019

can we not merge that other PR first and just publish a release? then we'd have an OmniSharp release based on 3.3.1 which matches the latest VS preview

then we merge this PR to get one onto 3.4, I think that would be most desirable course of action

@rchande
Copy link
Author

rchande commented Sep 10, 2019

From the C# extension side we're likely going to try to align with .Net Core 3.1 preview 1, which this build covers, in the next 2 weeks. I doubt we'll ship another release sooner than that. Does that make sense?

@filipw
Copy link
Member

filipw commented Sep 10, 2019

shouldn't we wait for a later 3.4 build then?

@filipw
Copy link
Member

filipw commented Sep 10, 2019

actually we can update again at any point - thanks

@filipw filipw merged commit 293d52d into OmniSharp:master Sep 10, 2019
@rchande
Copy link
Author

rchande commented Sep 10, 2019

@filipw Thanks for accommodating us :)

@rchande rchande deleted the update-roslyn-3 branch September 10, 2019 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants