Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
do not set mono paths in standalone mode #1656
Since we now run in stand alone mode on top of mono 6.4.0 and raised the global mono minimum version to 6.4.0, we should not need to set mono paths in stand alone mode anymore.
This fixes OmniSharp/omnisharp-vscode#3410 and fixes OmniSharp/omnisharp-vscode#3340 and a couple of other issues that I need to dig up (also lots of errors were reported as comments under old closed issues). In short the problem was, if you have old Mono (say 5.4.0) installed, we don't pick it as global Mono as it's < 6.4.0 and run in standalone mode. However we still set:
which causes .NET Core 3.0 to fail.
By the way, the tests explicitly avoided to set any mono paths, so any problem with this, and users reported plenty, only ever manifested itself only once running OmniSharp server in real world.