Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not set mono paths in standalone mode #1656

Merged
merged 3 commits into from Nov 23, 2019
Merged

Conversation

@filipw
Copy link
Member

filipw commented Nov 22, 2019

Since we now run in stand alone mode on top of mono 6.4.0 and raised the global mono minimum version to 6.4.0, we should not need to set mono paths in stand alone mode anymore.

This fixes OmniSharp/omnisharp-vscode#3410 and fixes OmniSharp/omnisharp-vscode#3340 and a couple of other issues that I need to dig up (also lots of errors were reported as comments under old closed issues). In short the problem was, if you have old Mono (say 5.4.0) installed, we don't pick it as global Mono as it's < 6.4.0 and run in standalone mode. However we still set:

TargetFrameworkRootPath = /Library/Frameworks/Mono.framework/Versions/5.4.0/lib/mono/xbuild-frameworks
MSBuildExtensionsPath = /Library/Frameworks/Mono.framework/Versions/5.4.0/lib/mono/xbuild

which causes .NET Core 3.0 to fail.

By the way, the tests explicitly avoided to set any mono paths, so any problem with this, and users reported plenty, only ever manifested itself only once running OmniSharp server in real world.

filipw added 3 commits Nov 21, 2019
@filipw filipw requested review from JoeRobich, david-driscoll and mholo65 Nov 22, 2019
@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Nov 22, 2019

fixes #1650 too

Copy link
Collaborator

JoeRobich left a comment

LGTM

@mholo65 mholo65 merged commit 862f16f into master Nov 23, 2019
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn #1.34.9-PullRequest1656.6 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
@mholo65

This comment has been minimized.

Copy link
Member

mholo65 commented Nov 23, 2019

Thanks!

@mholo65 mholo65 deleted the bugfix/mono-standalone-monopaths branch Nov 23, 2019
filipw added a commit to filipw/omnisharp-roslyn that referenced this pull request Nov 25, 2019
filipw added a commit that referenced this pull request Nov 26, 2019
added #1656 to the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.