Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #line directive in find references #1660

Merged
merged 7 commits into from Dec 5, 2019

Conversation

@filipw
Copy link
Member

filipw commented Nov 29, 2019

Fixes #1649
If the mapping goes to an external file, we assume column 0,0

filipw added 4 commits Nov 29, 2019
@filipw filipw requested review from JoeRobich, david-driscoll and mholo65 Nov 29, 2019
@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Nov 29, 2019

@mholo65 Cake tests fail with this, should I exclude Cake from this span mapping logic?

@mholo65

This comment has been minimized.

Copy link
Member

mholo65 commented Nov 30, 2019

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Dec 4, 2019

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

did you get a chance to look at this?

@mholo65

This comment has been minimized.

Copy link
Member

mholo65 commented Dec 4, 2019

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

did you get a chance to look at this?

I'm looking now.

mholo65 and others added 3 commits Dec 4, 2019
Exclude Cake files from line span mapping
@mholo65
mholo65 approved these changes Dec 5, 2019
@filipw

This comment has been minimized.

Copy link
Member Author

filipw commented Dec 5, 2019

thanks @mholo65

should be good to go

@mholo65 mholo65 merged commit 3a331cd into OmniSharp:master Dec 5, 2019
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn #1.34.9-PullRequest1660.24 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.