Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support #line directive in find references #1660

Merged
merged 7 commits into from Dec 5, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Nov 29, 2019

Fixes #1649
If the mapping goes to an external file, we assume column 0,0

@filipw
Copy link
Member Author

filipw commented Nov 29, 2019

@mholo65 Cake tests fail with this, should I exclude Cake from this span mapping logic?

@bjorkstromm
Copy link
Member

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

@filipw
Copy link
Member Author

filipw commented Dec 4, 2019

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

did you get a chance to look at this?

@bjorkstromm
Copy link
Member

@filipw let me have a look at the Cake, and see if I can fix it. Cake, behind the scenes uses a lot of #line mappings, as we basically merge all #loaded files + DSL into one giant csx with custom host which we pass to Roslyn.

did you get a chance to look at this?

I'm looking now.

@filipw
Copy link
Member Author

filipw commented Dec 5, 2019

thanks @mholo65

should be good to go

@bjorkstromm bjorkstromm merged commit 3a331cd into OmniSharp:master Dec 5, 2019
@filipw filipw deleted the feature/line-references branch May 12, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support line pragmas for find all references
2 participants