Update Mono to 6.8.0 #1697
Update Mono to 6.8.0 #1697
Conversation
JoeRobich
force-pushed
the
update-mono-6.8.0
branch
from
8779c26
to
3b38e6f
Compare
|
during the .NET Core 3.0 debacle with msbuild 16.3 the build script was updated to copy MSBuild from global mono at the build agent, instead of these zips. probably time to revert this 😁 |
You mean rely purely on the MSBuild zip files? |
|
I am talking about this change #1612 would you mind reverting it as part of this PR? otherwise we have older MSBuild in the released packages... |
|
Ah, gotcha. Sure thing. |
|
the alternative is to remove them from the JSON completely as they are not used at the moment and update build agents to 6.8.0 too so that it's in line with the bundled runtime when it comes to MSBuild |
|
I somehow don't have access to that blob storage and when we needed to urgently update to MSBuild 16.3 due to the breaking changes in .NET SDK, and Ravi was unreachable, the best and quickest idea I had was to copy from the global Mono at build time instead 😅 that's the reason behind that change in the first place, in case you were wondering... (sorry for slow responses, typing on mobile) |
|
@filipw I think building it from the build script is probably the way to go. It looks like the build script was already augmenting the msbuild zips anyways, |
|
OK makes sense to me. maybe let's just align the versions here https://github.com/OmniSharp/omnisharp-roslyn/blob/master/azure-pipelines.yml#L59 and https://github.com/OmniSharp/omnisharp-roslyn/blob/master/azure-pipelines.yml#L93 with the embedded runtime ones |
JoeRobich
force-pushed
the
update-mono-6.8.0
branch
from
1bb1a7f
to
af55c03
Compare
|
In light of the way the Linux and MacOS legs failed. We may want to update this to the 6.8.0.105 version that just dropped. |
Mono 6.6.0 added a dependency on libintl that ships in the Mono pkg (mono/mono#18531). This dependency has been removed from later builds of 6.8.0.
Tested locally with 6.8.0.96 and saw failures. The stable MacOS release of 6.8.0.104 contains the fix. Linux builds use 6.8.0.96 as that is the released stable build.
Resolves #1693
Resolves dotnet/vscode-csharp#3545