Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mono to 6.8.0 #1697

Merged
merged 4 commits into from Feb 5, 2020
Merged

Update Mono to 6.8.0 #1697

merged 4 commits into from Feb 5, 2020

Conversation

@JoeRobich
Copy link
Collaborator

JoeRobich commented Feb 4, 2020

Mono 6.6.0 added a dependency on libintl that ships in the Mono pkg (mono/mono#18531). This dependency has been removed from later builds of 6.8.0.

Tested locally with 6.8.0.96 and saw failures. The stable MacOS release of 6.8.0.104 contains the fix. Linux builds use 6.8.0.96 as that is the released stable build.

Resolves #1693
Resolves OmniSharp/omnisharp-vscode#3545

@JoeRobich JoeRobich requested a review from filipw Feb 4, 2020
@JoeRobich JoeRobich force-pushed the JoeRobich:update-mono-6.8.0 branch from 8779c26 to 3b38e6f Feb 4, 2020
@filipw

This comment has been minimized.

Copy link
Member

filipw commented Feb 4, 2020

during the .NET Core 3.0 debacle with msbuild 16.3 the build script was updated to copy MSBuild from global mono at the build agent, instead of these zips. probably time to revert this 😁

@JoeRobich

This comment has been minimized.

Copy link
Collaborator Author

JoeRobich commented Feb 4, 2020

probably time to revert this

You mean rely purely on the MSBuild zip files?

@filipw

This comment has been minimized.

Copy link
Member

filipw commented Feb 4, 2020

I am talking about this change #1612

would you mind reverting it as part of this PR?

otherwise we have older MSBuild in the released packages...

@JoeRobich

This comment has been minimized.

Copy link
Collaborator Author

JoeRobich commented Feb 4, 2020

Ah, gotcha. Sure thing.

@filipw

This comment has been minimized.

Copy link
Member

filipw commented Feb 4, 2020

the alternative is to remove them from the JSON completely as they are not used at the moment and update build agents to 6.8.0 too so that it's in line with the bundled runtime when it comes to MSBuild

@filipw

This comment has been minimized.

Copy link
Member

filipw commented Feb 4, 2020

I somehow don't have access to that blob storage and when we needed to urgently update to MSBuild 16.3 due to the breaking changes in .NET SDK, and Ravi was unreachable, the best and quickest idea I had was to copy from the global Mono at build time instead 😅 that's the reason behind that change in the first place, in case you were wondering...

(sorry for slow responses, typing on mobile)

@JoeRobich

This comment has been minimized.

Copy link
Collaborator Author

JoeRobich commented Feb 4, 2020

@filipw I think building it from the build script is probably the way to go. It looks like the build script was already augmenting the msbuild zips anyways,

@filipw

This comment has been minimized.

Copy link
Member

filipw commented Feb 4, 2020

@JoeRobich JoeRobich force-pushed the JoeRobich:update-mono-6.8.0 branch from 1bb1a7f to af55c03 Feb 5, 2020
@filipw
filipw approved these changes Feb 5, 2020
Copy link
Member

filipw left a comment

thanks!

@JoeRobich

This comment has been minimized.

Copy link
Collaborator Author

JoeRobich commented Feb 5, 2020

In light of the way the Linux and MacOS legs failed. We may want to update this to the 6.8.0.105 version that just dropped.

@filipw filipw merged commit 1fc6009 into OmniSharp:master Feb 5, 2020
6 checks passed
6 checks passed
OmniSharp.omnisharp-roslyn Build #1.34.11-PullRequest1697.22 succeeded
Details
OmniSharp.omnisharp-roslyn (GitVersion) GitVersion succeeded
Details
OmniSharp.omnisharp-roslyn (Linux) Linux succeeded
Details
OmniSharp.omnisharp-roslyn (Release) Release succeeded
Details
OmniSharp.omnisharp-roslyn (Windows) Windows succeeded
Details
OmniSharp.omnisharp-roslyn (macOS) macOS succeeded
Details
Copy link

ifuseandprint left a comment

@

@ifuseandprint

This comment has been minimized.

Copy link

ifuseandprint commented Feb 9, 2020

Duplicate of #

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.