Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run dotnet --info once for the working directory #1925

Merged
merged 3 commits into from
Sep 1, 2020

Conversation

filipw
Copy link
Member

@filipw filipw commented Sep 1, 2020

At the moment we run dotnet --info twice in the working directory when OmniSharp starts up.
This PR changes it to be once only, shaving about 300ms from the startup time (on my machine).

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@david-driscoll david-driscoll merged commit 304c1d7 into master Sep 1, 2020
@filipw filipw deleted the feature/singledotnetinfo branch September 30, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants