Adds support for /completion and /completion/resolve endpoints for Cake. #1944
Conversation
bjorkstromm
commented
Sep 15, 2020
bjorkstromm
commented
- Fixes Missing Cake Response handlers in V1.37.1 #1939
| // [Fact] | ||
| // public async Task ShouldGetCompletionWithAdditionalTextEdits() | ||
| // { | ||
| // const string input = @"Regex.Repl$$"; |
There was a problem hiding this comment.
Anyone know how to get a completion with Additional Text? In Cake, e.g. we don't have System.Text.RegularExpressions namespace imported by default. This was my attempt to get a completion from CompletionItemExtensions.TypeImportCompletionProvider. I also tried var regex == new Rege$$, but that didn't work.
There was a problem hiding this comment.
it's disabled by default, you need to pass in an option RoslynExtensionsOptions:EnableImportCompletion
https://github.com/OmniSharp/omnisharp-roslyn/blob/master/tests/OmniSharp.Roslyn.CSharp.Tests/CompletionFacts.cs#L1399
There was a problem hiding this comment.
Auch! Does AdditionalTextEdits always contain the whole buffer? //cc @333fred
There was a problem hiding this comment.
Unfortunately, yes.
Thanks for the quick reply. In that case I think I'll just remove all additional texts for Cake files. Can Completion return Additional text, or is it just the Resolver that adds this?
There was a problem hiding this comment.
Override completion can do this as well, and those are not usually so long.
There was a problem hiding this comment.
Thanks! I managed to get override completion in at least. Or if it doesn't bring in an unimported type.
