Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build tool version for NET 5 RC2 #1971

Merged
merged 6 commits into from
Oct 6, 2020

Conversation

nohwnd
Copy link
Contributor

@nohwnd nohwnd commented Oct 5, 2020

No description provided.

@filipw
Copy link
Member

filipw commented Oct 5, 2020

please update the tests too - see #1953 for reference
EDIT: oh it's not officially available yet, then it can wait for now

tools/packages.config Outdated Show resolved Hide resolved
@JoeRobich
Copy link
Member

I updated the MSBuild pacakging so that all platforms now use the "net472" resolvers.

@filipw
Copy link
Member

filipw commented Oct 5, 2020

@JoeRobich I am not sure I get the change. so it first copies the Mono ref assemblies from global Mono but then overwrites whatever it can from Nuget, correct?

@JoeRobich
Copy link
Member

JoeRobich commented Oct 5, 2020

so it first copies the Mono ref assemblies from global Mono but then overwrites whatever it can from Nuget, correct?

@filipw Yes, it is doing the same thing that master is presently doing. I just refactored so that the common steps are more apparent. Since some targets and ref assemblies are needed from Mono's MSBuild, we copy those over first, since they are not in the MSBuild NuGets. We then overwrite with the version of MSBuild we want to ship with from the NuGet. I can update the list of MSBuild runtime targets and props so that we are only copying over what isn't present in the NuGets.

The actual change is that we use the "net472" resolvers on all platforms as RC2 doesn't ship with "netstandard2.0" resolvers.

@nohwnd nohwnd marked this pull request as ready for review October 6, 2020 15:11
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@filipw
Copy link
Member

filipw commented Oct 6, 2020

shall we upgrade Roslyn too?

@filipw filipw merged commit 8c35bd9 into OmniSharp:master Oct 6, 2020
@JoeRobich
Copy link
Member

shall we upgrade Roslyn too?

Sure. Let me see what we are likely shipping in 16.8 Preview 4.

@nohwnd
Copy link
Contributor Author

nohwnd commented Oct 6, 2020

@JoeRobich did I miss more entries in that xml?

@JoeRobich
Copy link
Member

JoeRobich commented Oct 6, 2020

@nohwnd You didn't miss anything in this PR. Prior to an OmniSharp release it is nice to bump the Roslyn used by the language services as well. see #1974. In this case I thought I would help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants