Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions to match .NET SDK 6 RC1 #2217

Closed

Conversation

nohwnd
Copy link
Contributor

@nohwnd nohwnd commented Aug 30, 2021

No description provided.

@filipw
Copy link
Member

filipw commented Aug 30, 2021

These test failures look like a real issue - because it fails when loading projects with 5.0.302 SDK

   [fail]: OmniSharp.MSBuild.ProjectLoader
1456
                The "GetReferenceNearestTargetFrameworkTask" task failed unexpectedly.
1457
                System.MissingMethodException: Method not found: 'NuGet.Frameworks.NuGetFramework NuGet.Frameworks.NuGetFramework.ParseComponents(System.String, System.String)'.
1458
                   at NuGet.Build.Tasks.GetReferenceNearestTargetFrameworkTask.TryParseFramework(String targetFrameworkMoniker, String targetPlatformMoniker, String errorMessage, MSBuildLogger logger, NuGetFramework& nugetFramework)
1459
                   at NuGet.Build.Tasks.GetReferenceNearestTargetFrameworkTask.Execute()
1460
                   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
1461
                   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()   [fail]: OmniSharp.MSBuild.ProjectLoader
1456
                The "GetReferenceNearestTargetFrameworkTask" task failed unexpectedly.
1457
                System.MissingMethodException: Method not found: 'NuGet.Frameworks.NuGetFramework NuGet.Frameworks.NuGetFramework.ParseComponents(System.String, System.String)'.
1458
                   at NuGet.Build.Tasks.GetReferenceNearestTargetFrameworkTask.TryParseFramework(String targetFrameworkMoniker, String targetPlatformMoniker, String errorMessage, MSBuildLogger logger, NuGetFramework& nugetFramework)
1459
                   at NuGet.Build.Tasks.GetReferenceNearestTargetFrameworkTask.Execute()
1460
                   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
1461
                   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()

@nohwnd
Copy link
Contributor Author

nohwnd commented Aug 30, 2021

That overload for ParseComponents seems to be introduced here, so probably the NuGet.Frameworks assembly in that SDK does not have the change yet.

NuGet/NuGet.Client@935b1d2

What is the usual way to fix this? Adding dependency to this package for that assembly?

@nohwnd
Copy link
Contributor Author

nohwnd commented Aug 30, 2021

What is the usual way to fix this? Adding dependency to this package for that assembly?

Tried that, it does not help.

@filipw
Copy link
Member

filipw commented Aug 30, 2021

@JoeRobich is the one person that knows how to navigate the muddy waters of Nuget DLLs 😀

@JoeRobich
Copy link
Member

Closed as these changes were part of #2218

@JoeRobich JoeRobich closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants