Add Custom .NET CLI support to OmniSharp #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…custom .NET CLI, with a fallback to the DOTNET_ROOT environment variable before falling back to the PATH. I've updated the tests to use this functionality for locating the .NET CLI instead of using the old test-only code-path. As this is my first contribution to Omnisharp, I'm not quite sure how this exposes the new setting through to omnisharp.json, so if anyone has any pointers on that, they would be well appreciated.
jkoritzinsky
added a commit
to jkoritzinsky/omnisharp-vscode
that referenced
this pull request
Sep 2, 2021
|
cc: @filipw can you take a look at this PR when you have a chance? |
333fred
approved these changes
Sep 21, 2021
| if (File.Exists(Path.Combine(path, $"dotnet{executableExtension}"))) | ||
| { | ||
| // We'll take the first path that has a dotnet executable. | ||
| DotNetPath = Path.Combine(path, "dotnet"); |
There was a problem hiding this comment.
I believe we need a break; here. Currently, it will continue looping the location paths and take the last path that has a dotnet executable. If you agree, I can push a PR for that.
There was a problem hiding this comment.
I think you're right, so a PR is probably worthwhile.
|
FWIW, it kind of looks like this runs before the omnisharp.json files are loaded. ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration mechanism to allow users to point OmniSharp to a custom .NET CLI, with a fallback to the DOTNET_ROOT environment variable before falling back to the PATH.
I've updated the tests to use this functionality for locating the .NET CLI instead of using the old test-only code-path.
As this is my first contribution to Omnisharp, I'm not quite sure how this exposes the new setting through to omnisharp.json, so if anyone has any pointers on that, they would be well appreciated.
cc: @333fred